Refactor/Move block processor in test to DI.#8959
Merged
Merged
Conversation
ced19c9 to
1201ab1
Compare
273e14b to
a577fd0
Compare
6 tasks
33341c2 to
ccc1572
Compare
6214f02 to
a3828ba
Compare
LukaszRozmej
approved these changes
Jul 14, 2025
| public ProducedBlockSuggester Suggester { get; protected set; } = null!; | ||
|
|
||
| public IExecutionRequestsProcessor MainExecutionRequestsProcessor => ((MainBlockProcessingContext)_fromContainer.MainProcessingContext).LifetimeScope.Resolve<IExecutionRequestsProcessor>(); | ||
| public IExecutionRequestsProcessor MainExecutionRequestsProcessor => ((AutoMainProcessingContext)_fromContainer.MainProcessingContext).LifetimeScope.Resolve<IExecutionRequestsProcessor>(); |
Contributor
Author
There was a problem hiding this comment.
There is already MainProcessingContext in prod. Its manual and not auto.
| } | ||
|
|
||
| // simulating restarts - we stopped the old blockchain processor and create the new one | ||
| _currentBlockchainProcessor = new BlockchainProcessor(BlockTree, BlockProcessor, |
Member
There was a problem hiding this comment.
shouldn't it support different IBlockchainProcessor types? (We really have one major now, so maybe not)
Contributor
Author
There was a problem hiding this comment.
Its probably fine for this specific test suite. Otherwise, I'd have to make sure blockchain processor is restartable just for this test.
ccc1572 to
ffb4e0c
Compare
a3828ba to
50eb2bc
Compare
ffb4e0c to
8da1902
Compare
50eb2bc to
823b270
Compare
tanishqjasoria
approved these changes
Jul 25, 2025
Base automatically changed from
fix/aura-merge-missed-witdhrawal-processorr
to
master
July 25, 2025 22:54
823b270 to
d4b992c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require #8950
BlockProcessorconstructor call to make it easy to split.TestBlockchainto DI.CliqueBlockProducerTestto DI.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing