fix: event triggering docs#1372
Merged
savingoyal merged 4 commits intoevent-triggeringfrom Apr 25, 2023
Merged
Conversation
savingoyal
approved these changes
Apr 25, 2023
savingoyal
added a commit
that referenced
this pull request
Apr 25, 2023
* WIP: Integrate with Argo Events * events * auto-emit events * address sensor deregistration * stuff more information in auto events * changes * mo event changes * flip parameter mappings * introduce trigger metadata in current * black cleanup * emit triggering metadata to db * support trigger_on_finish * set event ids * introduce metaflow trigger * block sfn and airflow for @trigger * introduce options * fix timestamp return type and add checks * more checks * fix namespaces * more changes * more ux polish * address comments * remove references to AND * address feedback for metaflow trigger * address client changes * add config vars for webhooks * updates to event triggering * more changes * changes * address feedback * address changes * add docs * clean up trigger * introduce window * remove hardcodes * address pending comments * add todo comments * move back event names * clean up code * address feedback * support prod namespace * address comments * address bugs * final fix * fix: event triggering docs (#1372) * explicitly return None for trigger * address review comments * polishing events docstrings * update event decorator types in docstring --------- Co-authored-by: Sakari Ikonen <64256562+saikonen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address some review comments