This repository was archived by the owner on Dec 13, 2023. It is now read-only.
fixed task card open in Chrome and Firefox#3447
Merged
v1r3n merged 3 commits intoNetflix:mainfrom May 3, 2023
Merged
Conversation
ceisen1
reviewed
Jan 20, 2023
|
|
||
| handleClick = (e) => { | ||
| const taskRef = e.path[1].id || e.path[2].id; // could be 2 layers down | ||
| const taskRef = this.getTaskRef(e); |
Contributor
There was a problem hiding this comment.
I made the same comment on 3442 as it seems like this PR Addresses the same issue:
I believe this could be made simpler with event.composedPath(). Chrome recommends updating to this for the now deprecated event.path API https://chromestatus.com/feature/5726124632965120.
It also seems to be compatible with all major browsers https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath#browser_compatibility
Contributor
|
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days. |
Contributor
|
@sourabh30 can you resolve the conflicts? |
Contributor
|
@sourabh30 gentle ping. |
Contributor
Author
|
@v1r3n I believe it is resolved now. Can you please check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Issue #3442
Users can't click on the task at the flow diagram to open the right-side panel while using Firefox or Chrome browser.
Describe the new behavior from this PR, and why it's needed
Issue #3442 - Updated the code base to fix the task.