This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Merged
Conversation
Event.path is deprecated in chrome as of the last update https://chromestatus.com/feature/5726124632965120. This is causing a bug when clicking on a task in the UI. This is also see in safari: Netflix#3330. Updating to use composedPath() instead per guidance. This is compatible with all browsers: https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath
This was referenced Jan 23, 2023
Contributor
|
Thanks for the PR. For reference, Conductor UI has been moved to a separate repo here: https://github.com/Netflix/conductor-ui which already incorporates this fix. The UI directory on this repo is on code freeze. However given the impact of this breakage I think it is sensible to merge your PR. |
peterlau
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Event.path is deprecated in chrome as of the last update https://chromestatus.com/feature/5726124632965120. This is causing a bug when clicking on a task in the UI. This is also see in safari: #3330. Updating to use composedPath() instead per guidance.
This is compatible with all browsers:
https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath
See the error we are seeing in the Chrome UI below
Describe the new behavior from this PR, and why it's needed
Issue #
#3330