Conversation
agramfort
added a commit
that referenced
this pull request
Jul 24, 2013
nitpick fixes, pep8 and fix math equations
Because sklearn classifier need not to use *args and **wargs, we cannot use decorators on init class FIX CCA and _CCA need to be skipped on a bunch of tests because the code is very unreliable
…om the correct module
one last _pls missing in the documentation...
TEST don't need to excluse _PLS and _CCA
NelleV
pushed a commit
that referenced
this pull request
Jul 26, 2013
ENH added the fork me ribbon to the website
NelleV
pushed a commit
that referenced
this pull request
Apr 28, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a small pull request that refactors the PLS module to split it into two modules, the CCA module and the PLS module.
The only method that moved is the CCA method. It has been deprecated from the pls module, and moved to it's own module.
Thanks,