Add comprehensive test coverage for WealthsimplePosition#265
Merged
Conversation
Co-authored-by: Nef10 <4551135+Nef10@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Test coverage for WealthsimplePosition struct
Add comprehensive test coverage for WealthsimplePosition struct
Sep 2, 2025
|
Minimum coverage required: 57%
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Nef10
added a commit
that referenced
this pull request
Sep 3, 2025
* main: Add test coverage for WealthsimplePosition struct (#265) # Conflicts: # Tests/WealthsimpleTests/Helpers/MockURLProtocol.swift
Nef10
added a commit
that referenced
this pull request
Sep 3, 2025
* main: Add test coverage for WealthsimpleTransaction and TransactionError Add test coverage for WealthsimplePosition struct (#265) # Conflicts: # Tests/WealthsimpleTests/Helpers/MockURLProtocol.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive test coverage for the
WealthsimplePositionstruct, following the existing patterns established inTokenTestsandWealthsimpleAccountTests. The implementation includes 24 new test cases that cover all code paths and error scenarios.Key Changes
New Test File:
WealthsimplePositionTests.swiftEnhanced Mock Infrastructure
MockURLProtocolto support positions endpoint requestsgetPositionsRequestHandlerfor consistent mocking patternsWealthsimplePosition Improvements
Equatableconformance toPositionErrorenum for proper test assertionsTest Coverage Details
The tests comprehensively cover:
PositionErrorcases includingnoDataReceived,httpError,invalidJson,invalidJsonType,missingResultParamenter,invalidResultParamenter,assetErrorAll tests follow the established patterns in the codebase, use proper mocking without external network calls, and maintain the project's high code quality standards. SwiftLint warnings for file and class length have been appropriately suppressed as permitted by the issue requirements.
Fixes #260.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.