Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Necrom4/sbb-tui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.1
Choose a base ref
...
head repository: Necrom4/sbb-tui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.2
Choose a head ref
  • 8 commits
  • 17 files changed
  • 3 contributors

Commits on Mar 28, 2026

  1. docs: add CONTRIBUTING.md

    @Necrom4
    Necrom4 authored Mar 28, 2026
    Configuration menu
    Copy the full SHA
    23d5d83 View commit details
    Browse the repository at this point in the history

  2. docs: add issue templates 

    This is a test
    @Necrom4
    Necrom4 authored Mar 28, 2026
    Configuration menu
    Copy the full SHA
    01b9356 View commit details
    Browse the repository at this point in the history

  3. Revert "docs: add issue templates" 

    This reverts commit 01b9356.

NOTE: Will add this back some day when I've created a template I like.
    @Necrom4
    Necrom4 committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    93173b0 View commit details
    Browse the repository at this point in the history

  4. refactor(views): split monolithic view.go into focused files 

    Split the 1155-line views/view.go into 6 files organized by
responsibility following Bubbletea's Elm architecture convention:
model.go, update.go, view.go, connection.go, styles.go, icons.go.

No functional changes - pure architectural reorganization.
    @Necrom4
    Necrom4 committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    b23bf92 View commit details
    Browse the repository at this point in the history

  5. refactor: apply Go naming conventions across the codebase 

    Package renames following Go singular convention:
- models/ -> model/, views/ -> ui/
- Delete utils/ (Go anti-pattern), inline helpers at call sites

Type and field renames for clarity:
- SBBDateLayout -> Timestamp
- Departure.Departure -> Departure.Scheduled (avoids section.Departure.Departure)
- Arrival.Arrival -> Arrival.Scheduled (same)
- Connection.FromData/ToData -> Connection.From/To
- model type -> appModel (avoids collision with package name)

Function renames following Go conventions:
- InitialModel -> NewModel (constructor convention)
- LoadThemeConfig -> LoadTheme (reduce stutter)
- getGoogleMapsURL -> googleMapsURL (no get prefix)
- validateInputs returns error instead of string

Naming cleanup:
- Expand cryptic abbreviations in icons (arr->arrival, vhc->vehicle, etc.)
- Expand layout constants (hdrHeight->headerHeight, rsltMrgn->resultMargin, etc.)
- Unexport internal-only symbols (KindInput, DataMsg, FileConfig, etc.)
- Fix import ordering (stdlib, external, internal) across all files
- Add doc comments to exported symbols
- Move APIResponse into api/ as unexported connectionsResponse
- Remove dead code (Input struct, Capacity1st/2nd fields)
    @Necrom4
    Necrom4 committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    b64aba5 View commit details
    Browse the repository at this point in the history

  6. fix: change string according to diagnostics 

    - error strings should not be capitalized
- error strings should not end with punctuation or newlines
    @Necrom4
    Necrom4 committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    ea98295 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #21 from Necrom4/refactor/split-views 

    Refactor project architecture
    @Necrom4
    Necrom4 authored Mar 28, 2026
    Configuration menu
    Copy the full SHA
    a30f347 View commit details
    Browse the repository at this point in the history

  8. chore(release): 1.8.2 [skip ci] 

    ## [1.8.2](v1.8.1...v1.8.2) (2026-03-28)

### Bug Fixes

* change string according to diagnostics ([ea98295](ea98295))
    @semantic-release-bot
    semantic-release-bot committed Mar 28, 2026
    Configuration menu
    Copy the full SHA
    4904f3f View commit details
    Browse the repository at this point in the history
Loading