Skip to content

[DRAFT] [WIP] Feat: share text to KISS#2111

Closed
ram-a-dhan wants to merge 6 commits into
Neamar:masterfrom
ram-a-dhan:feat-share-to-kiss
Closed

[DRAFT] [WIP] Feat: share text to KISS#2111
ram-a-dhan wants to merge 6 commits into
Neamar:masterfrom
ram-a-dhan:feat-share-to-kiss

Conversation

@ram-a-dhan

Copy link
Copy Markdown
Contributor

Summary: New feature proposal for sharing text from anywhere into KISS search bar for quicker searching experience

General Idea

This is a WIP proposal to streamline the user experience of searching using KISS launcher. It works by sharing texts
(or web links) from almost anywhere on the phone into the KISS launcher's search bar via android's Sharesheet.

Background

I can't say for sure that i can speak for every user, but based on my experience in using KISS for almost every web (or play store, google maps location, local e-commerce, etc) search, i always find it a bit tedious and too repetitive to highlight the text i want, tap the "Copy" option, open KISS, long-tap KISS search input, and finally tap the "Paste" option before picking the search engine i want to search it with.

Why not just use the "Web Search" option in the highlighted text's context menu?

The "Web Search" option only uses the default search engine of the current browser i'm using. And when outside of browser environment, i only get the "Google App" option, which is frustrating to say the least. For context, i frequently jump between search engines and also between browsers. I have more than 3 search engines that i use daily for cross-referencing sources and comparing SEO results. I have more than 2 browsers for different needs (i have not set a default browser so i can always pick whichever i want everytime i search) as i don't want to mix up the browsing history (e.g. personal searches, workplace searches, people borrowing my phone for quick searches, etc).

Why not use DuckDuckGo's Bangs?

DDG's Bangs requires inclusion of pre-determined non-customizable prefix text to the search keyword, which would mean more hoops to jump through than i currently have to do. Besides , this problem is already solved by KISS launcher's list of search provider. The fewer steps one has to make the better and KISS launcher is already a huge step in the right direction, just needs one more :)

What changes code-wise?

  • AndroidManifest.xml: added intent-filter for registering KISS launcher as a sharing option in context menus.
  • MainActivity.java: added handler inside onCreate for the received Intent.EXTRA_TEXT and setting the text value of searchEditText with it; complete with error toast fallback.
  • strings.xml (EN) + strings-.xml (IN): added error message text and 1 translation for my native language (the correct country code is ID and not IN btw :P ).

Have you tested it yourself? Where are the screenshots?

I haven't. That's why this PR is labeled as [DRAFT] [WIP]. I don't have access to a powerful enough machine to run Android Studio to build and test it myself for now. I even made these proposed changes directly from this website 🤪 . I am still going to finish this PR, just not now. If anybody is also interested in this proposed feature and DO can build and test it as soon as it takes, please do share the results here. 🙇

So what now?

I will build and test it myself when i have a suitable hardware for it. No exact time that i can tell, but i will commit to this, because i need this, except if this PR is deemed unsuitable by the maintainers. Then i would (probably) keep this fork a little longer. In the meantime i accept reviews, critiques, and suggestions. I will do as best as i can to get this PR acceptable.

Terima kasih atas perhatian dan pertimbangannya
Matur nuwun 🙏

add intent filter for showing KISS launcher in Sharesheets from other apps or from context menu sharing
if text is not empty, then paste it to the search bar, else, show toast message saying it's empty
@github-actions github-actions Bot added the Stale label Mar 26, 2024
@github-actions github-actions Bot closed this Apr 25, 2024
TBog added a commit to TBog/TBLauncher that referenced this pull request Apr 25, 2024
@marunjar marunjar removed the Stale label May 12, 2024
@marunjar marunjar reopened this May 12, 2024

@marunjar marunjar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ram-a-dhan from my point of view this is almost fine. Can you please check comments for needed changes?
Also there are some merge conflicts which needs to be resolved before this can be merged.

Comment thread app/src/main/java/fr/neamar/kiss/MainActivity.java Outdated
Comment thread app/src/main/java/fr/neamar/kiss/MainActivity.java Outdated
Comment thread app/src/main/java/fr/neamar/kiss/MainActivity.java Outdated
@github-actions

Copy link
Copy Markdown

This PR is inactive because it has been open 60 days with no activity.
Remove inactive label or comment or this will be closed in 14 days.'

@github-actions github-actions Bot added the inactive This issue hasn't seen any activity recently. label Jul 15, 2024
@github-actions github-actions Bot closed this Aug 2, 2024
@marunjar marunjar reopened this Aug 4, 2024
@marunjar

marunjar commented Aug 4, 2024

Copy link
Copy Markdown
Collaborator

@ram-a-dhan can you please check merge conflicts in translation?
Everything else is fixed now and ready for merge.

@marunjar marunjar removed the inactive This issue hasn't seen any activity recently. label Aug 4, 2024
@github-actions

Copy link
Copy Markdown

This PR is inactive because it has been open 60 days with no activity.
Remove inactive label or comment or this will be closed in 14 days.'

@github-actions github-actions Bot added the inactive This issue hasn't seen any activity recently. label Oct 11, 2024
@github-actions github-actions Bot closed this Oct 29, 2024
@nubesurrealista

Copy link
Copy Markdown

Hey! I've merged this PR into my fork and can confirm that it's useful and works well. There are some conflicts, but they're easy to resolve. I think it's worth merging into KISS. @marunjar @ram-a-dhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive This issue hasn't seen any activity recently.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants