Skip to content

Atanasovg/navigation backstack #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hamorphis merged 4 commits into from
Sep 3, 2015
Merged

Atanasovg/navigation backstack #661

hamorphis merged 4 commits into from
Sep 3, 2015

Conversation

@atanasovg
Copy link
Contributor

@atanasovg atanasovg commented Sep 2, 2015

IMPORTANT Do not merge yet - we need unit tests & functional tests

API:

Exclude the main page from the backstack:

var application = require("application");

// mainEntry is of type "NavigationEntry"
application.mainEntry = {
    moduleName: "./main-page",
    backstackVisible: false
}

Navigate to a Page that should not be in the backstack

var frame = require("ui/frame");
var topFrame = frame.topmost();

topFrame.navigate({
    moduleName: "./some-inner-page",
    backstackVisible: false
});

TODO

  • Write unit tests
  • Write functional tests
  • Update the navigation article or create a new one, explaining how the feature works

Resolves #548

@ns-bot ns-bot added cla: yes and removed cla: no labels Sep 2, 2015
@ns-bot
Copy link

ns-bot commented Sep 2, 2015

❌

@dtopuzov
Copy link
Contributor

dtopuzov commented Sep 2, 2015

run ci

@ns-bot
Copy link

ns-bot commented Sep 2, 2015

❌

@dtopuzov
Copy link
Contributor

dtopuzov commented Sep 2, 2015

run ci

@ns-bot
Copy link

ns-bot commented Sep 2, 2015

❌

@dtopuzov
Copy link
Contributor

dtopuzov commented Sep 3, 2015

run ci

@ns-bot
Copy link

ns-bot commented Sep 3, 2015

❌

@hamorphis
Copy link
Contributor

hamorphis commented Sep 3, 2015

run ci

@ns-bot
Copy link

ns-bot commented Sep 3, 2015

❌

@hamorphis hamorphis merged commit cfe0902 into master Sep 3, 2015
@ns-bot
Copy link

ns-bot commented Sep 3, 2015

❌

@atanasovg atanasovg deleted the atanasovg/navigation-backstack branch September 24, 2015 14:01
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose public API controlling whether a Page should be added to the navigation backstack or not

5 participants

@atanasovg @ns-bot @dtopuzov @hamorphis