Vocabulary list on landing page: fallback to any language#1846
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
Vocabularies that didn't have a label in the current UI label were not visible on the landing page. See #1824
This PR fixes the problem by adding a fallback: if a vocabulary doesn't have a
dcterms:titlein the current UI language in the config.ttl file (and also doesn't have a title without a language tag), then Skosmos will just pick any title regardless of the language tag. This ensures that the vocabulary is visible, even though its name may not be in the expected language.The change also affects the vocabulary dropdown list in the global search bar: now vocabularies without a title in the current language are also shown in that list. (This caused some breakage for Cypress tests that didn't expect this.)
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
none
Checklist
.sr-onlyclass, color contrast)