Merged
Conversation
|
joelit
approved these changes
Dec 2, 2025
Contributor
joelit
left a comment
There was a problem hiding this comment.
LGTM! IMO duplicated lines in cypress tests are fine, and SonarQube should be ignored for those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reasons for creating this PR
See #1838. This implements truncation for the list of terms in other languages on the concept page:
Here is how the result looks like on the YKL/PLC page 32.1 Political systems:

Link to relevant issue(s), if any
Description of the changes in this PR
truncate-property-values.jsto also handle lists of terms in other languages, which has a somewhat different DOM structure than regular propertiesaltlabelwhich contains a concept that has very many English and Finnish language altlabelsaltlabelvocabularyKnown problems or uncertainties in this PR
global-search-bar.cy.jsbroke due to the addition of the newaltlabelvocabulary. For some reason thetestUnknownPropertyOrdervocabulary disappeared from the vocabulary selection menu and was replaced byaltlabel. I don't quite understand what happened here; why does the menu only show two vocabularies and not e.g. three? I modified the Cypress test accordingly, but there could be a bug hiding somewhere behind this strange behavior of the vocabulary selection menu.Checklist
.sr-onlyclass, color contrast)