Skip to content

Update library dependencies#1840

Merged
miguelvaara merged 2 commits intomainfrom
issue1837-update-library-dependencies
Nov 27, 2025
Merged

Update library dependencies#1840
miguelvaara merged 2 commits intomainfrom
issue1837-update-library-dependencies

Conversation

@miguelvaara
Copy link
Contributor

@miguelvaara miguelvaara commented Nov 27, 2025 •
edited
Loading

Reasons for creating this PR

To keep Skosmos up to date, secure and fully working

Link to relevant issue(s), if any

Description of the changes in this PR

All the tests pass except for the version number check in composer.json, which does not matter at this stage. I merged the changes that likely will come with your PR #1731

How does this approach look to you?

Known problems or uncertainties in this PR

I am not sure if the merge with the PR #1731 was the best move to do ...

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@miguelvaara miguelvaara requested a review from osma November 27, 2025 11:05
@miguelvaara miguelvaara self-assigned this Nov 27, 2025
@miguelvaara miguelvaara added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Nov 27, 2025
@miguelvaara miguelvaara moved this to Needs review in Skosmos 3.x Backlog Nov 27, 2025
@miguelvaara miguelvaara added this to the 3.0 milestone Nov 27, 2025
@miguelvaara
Update all dependencies to latest stable versions + fix EasyRDF 1.18.…
803f536 
…2 compatibility + Update the tests related to the EasyRDF changes so that the addition of the options is taken into account
@miguelvaara miguelvaara force-pushed the issue1837-update-library-dependencies branch from d179163 to 803f536 Compare November 27, 2025 12:18
@osma
Copy link
Member

osma commented Nov 27, 2025

Quick comments:

  1. I think we can drop symfony/polyfill-php80 and symfony/polyfill-php81, they are only useful for PHP versions below 8.0 / 8.1, and we are already requiring PHP 8.1 as a minimum.
  2. What about axe-core and cypress-axe, it looks like newer versions are available?
  3. Cypress also has much newer version available (15.7.0), should we try upgrading to that as well or is that too big a leap? (Could also be done in a separate PR if it's difficult)

@miguelvaara
Copy link
Contributor Author

miguelvaara commented Nov 27, 2025 •
edited
Loading

Quick comments:

  1. I think we can drop symfony/polyfill-php80 and `symfony/polyfill-php81...

Instructions for the design review:

Because Cypress was updated by two major versions, Node.js had to be updated to version 20. You can enable it temporarily in your shell like this:

source ~/.nvm/nvm.sh && nvm use 20 && node --version && npm --version

If everything works and you want to make Node 20 the default permanently:

source ~/.nvm/nvm.sh && nvm alias default 20 && nvm current

And if you change your mind and want to go back to the previous version, for example version 18, you obviously can do it like this:

source ~/.nvm/nvm.sh && nvm use 18 && node --version && npm --version

Cypress shouts at the following:
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@miguelvaara miguelvaara marked this pull request as ready for review November 27, 2025 13:52
osma
osma approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

I tested this locally, using the UI for manual testing and running the PHPUnit and Cypress tests. I couldn't find any issues. No new warnings printed to Apache logs or the browser console.

It looks like the Cypress upgrade finally solved a long-standing problem where concept-full-vs-partial.cy.js tests get stuck when you run them for a second time and you'd have to restart the Cypress GUI to make them work again 🎉

Excellent work!

@miguelvaara miguelvaara merged commit de16085 into main Nov 27, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 27, 2025
@osma osma deleted the issue1837-update-library-dependencies branch December 5, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osma osma osma approved these changes

Assignees

@miguelvaara miguelvaara

Labels

maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Update library dependencies

2 participants

@miguelvaara @osma