Skip to content

Upgrade to EasyRdf 1.18.*#1731

Merged
osma merged 6 commits intomainfrom
issue1700-upgrade-easyrdf
Nov 27, 2025
Merged

Upgrade to EasyRdf 1.18.*#1731
osma merged 6 commits intomainfrom
issue1700-upgrade-easyrdf

Conversation

@osma
Copy link
Member

@osma osma commented Dec 18, 2024 •
edited
Loading

Reasons for creating this PR

We should use recent versions of EasyRdf (see #1700). This PR upgrades EasyRdf from 1.13.1 to 1.18.*, fixing some mock resources in the test suite according to changes in that release and removing content negotiation tweaks that are no longer necessary with recent changes to the Accept header in EasyRdf.

Link to relevant issue(s), if any

Description of the changes in this PR

  • bump the EasyRdf dependency to 1.18.*
  • fix some mocked resources in tests
  • remove content negotiation tweaks from LinkedDataResource and WDQSResource

Known problems or uncertainties in this PR

none

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Dec 18, 2024
@osma osma added this to the 3.0 milestone Dec 18, 2024
@osma osma self-assigned this Dec 18, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@osma osma changed the title Upgrade to EasyRdf 1.14.0, fixing some mocked resources Upgrade to EasyRdf 1.14.0 Dec 18, 2024
@osma osma moved this from Needs review to Skosmos 3.0 Backlog (not this sprint) in Skosmos 3.x Backlog Mar 10, 2025
@osma osma mentioned this pull request Mar 13, 2025
Closed
5 tasks
@osma osma force-pushed the issue1700-upgrade-easyrdf branch from 4f4ef63 to 04ee3ed Compare October 28, 2025 08:41
@osma osma moved this from Skosmos 3.0 Backlog (not this sprint) to In progress in Skosmos 3.x Backlog Oct 28, 2025
@osma
Copy link
Member Author

osma commented Oct 28, 2025 •
edited
Loading

Rebased on current main and force-pushed. Let's see if we can push this further instead of stopping at 1.14.0. We now have a newer Fuseki thanks to #1775 / PR #1778 (Fuseki 5.3.0) and PR #1788 (Fuseki 5.4.0).

@osma
Copy link
Member Author

osma commented Oct 28, 2025

Nope, the tests are still failing for EasyRdf 1.14.1 and above (also tested newest EasyRdf release 1.17.0). It seems there is still a compatibility issue between EasyRdf 1.14.1+ and Fuseki. This should probably be investigated further and reported to EasyRdf.

@osma osma moved this from In progress to Skosmos 3.0 Backlog (not this sprint) in Skosmos 3.x Backlog Oct 28, 2025
@osma osma force-pushed the issue1700-upgrade-easyrdf branch from 04ee3ed to 608effc Compare November 24, 2025 14:38
@osma osma changed the title Upgrade to EasyRdf 1.14.0 Upgrade to EasyRdf 1.18.* Nov 24, 2025
@osma
Copy link
Member Author

osma commented Nov 24, 2025

The Fuseki compatibility issues have been sorted out in EasyRdf 1.18.0, so I bumped to that version. Also rebased on current main and force-pushed.

Sadly, there is another EasyRdf/Fuseki compatibility issue; the Turtle parser fails to parse empty CONSTRUCT query responses. Reported as sweetrdf/easyrdf#74

@osma osma modified the milestones: 3.x, 3.0 Nov 24, 2025
@osma osma mentioned this pull request Nov 26, 2025
Merged
@osma osma marked this pull request as ready for review November 26, 2025 14:24
@osma osma requested a review from joelit November 26, 2025 14:24
@osma osma moved this from Skosmos 3.0 Backlog (not this sprint) to Needs review in Skosmos 3.x Backlog Nov 26, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@osma
Copy link
Member Author

osma commented Nov 26, 2025

There was one more EasyRdf bug, in the RDF/XML parser. It is now fixed and 1.18.2 has been released with the fix.
This PR uses 1.18.2+ and everything seems to be working now.

@miguelvaara miguelvaara mentioned this pull request Nov 27, 2025
Merged
4 tasks
joelit
joelit approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@joelit joelit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - but I did find a bug in the handling of MIME-types: we have the same supported types for both vocabularies and concepts, but in fact we only support application/marcxml+xml on vocabulary level, not on concept level. If the MIME-type is requested for concept data
http://localhost/Skosmos/rest/v1/yso/data?format=application%2Fmarcxml%2Bxml&uri=http%3A%2F%2Fwww.yso.fi%2Fonto%2Fyso%2Fp8627&lang=fi
There should be an unsupported MIME-type message - but we don't get one, and we don't get marcxml either. Instead rdf-xml data is returned. I think this should be a separate bug report and this branch can be merged after that.

@osma osma merged commit fc5b926 into main Nov 27, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Nov 27, 2025
@osma osma deleted the issue1700-upgrade-easyrdf branch November 27, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelit joelit joelit approved these changes

Assignees

@osma osma

Labels

maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Update easyrdf from 1.13.1

2 participants

@osma @joelit