Remove unnecessary translation keys and messages#1820
Merged
miguelvaara merged 2 commits intomainfrom Nov 4, 2025
Conversation
osma
reviewed
Oct 30, 2025
osma
reviewed
Oct 30, 2025
… to the code according to the suggestions given in the PR review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reasons for creating this PR
We do not want to remove key–message pairs that are likely to be needed for translation again, as that would cause unnecessary and frustrating rework and slow down the completion of translations.
The situation is quite good (around 10 removed), but after the release of Skosmos 3, the list needs to be reviewed again, since some of the key–message pairs used in Skosmos 2 will probably end up unused.
Link to relevant issue(s), if any
#1813
Description of the changes in this PR
When a key–message pair in
messages.en.jsonshould be removedA key–message pair will be removed only if:
Searching for and evaluating usage cases
Open the attached file
messages.en-checklist.json, where:N→ the pair will be removed?→ uncertain, difficult to decideIn the Skosmos root directory, run:
Command-line helpers (in Skosmos root directory)
List all found translation keys and their states
Note:
The following command also lists as unused those key-message pairs in the language file whose key and message are identical (even if the message itself is used)
Go through all translation keys found in PHP, JS, and Twig code
When the translation file is finalized and merged into main, it can be pushed to Lokalise.
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)messages.en-checklist.json