Skip to content

Skosmos 3 configuration overhaul#1804

Merged
osma merged 6 commits intomainfrom
issue1793-skosmos3-configuration-overhaul
Aug 28, 2025
Merged

Skosmos 3 configuration overhaul#1804
osma merged 6 commits intomainfrom
issue1793-skosmos3-configuration-overhaul

Conversation

@osma
Copy link
Member

@osma osma commented Aug 27, 2025 •
edited
Loading

Reasons for creating this PR

Some Skosmos configuration parameters are redundant or badly named. With the upcoming release of Skosmos 3, we can clean up some of this legacy. See #1793

Link to relevant issue(s), if any

Description of the changes in this PR

  • renamed skosmos:uiHoneypotEnabled to skosmos:feedbackHoneypotEnabled (the ui is misleading)
  • renamed skosmos:uiHoneypotTime to skosmos:feedbackHoneypotTime (the ui is misleading)
  • simplified plugin configuration/activation: dropped support for skosmos:useParamPlugin and standalone skosmos:usePlugin; all configuration is now done using skosmos:globalPlugins and skosmos:vocabularyPlugins
  • dropped obsolete (already removed in Reimplement sidebar tabs and their configuration #1493) configuration options skosmos:showChangeList and skosmos:fullAlphabeticalIndex from the config files used in unit tests
  • make matching changes to config.ttl.dist; also change HTTP URLs to HTTPS for public SPARQL endpoints and vocabulary downloads in the file

Note: I've created a new wiki page Configuration for Skosmos 3 (+ added it to the wiki sidebar) and rewritten the section on Enabling Plugins in the wiki page Plugins for Skosmos 3 to match this PR.

Known problems or uncertainties in this PR

Not sure about skosmos:logCaughtExceptions. Is it still useful? Should it be dropped?

I have a feeling that there could be other configuration options that are no longer relevant for Skosmos 3, but it's hard to tell...

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma self-assigned this Aug 27, 2025
@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Aug 27, 2025
@osma osma added this to the 3.0-beta.1 milestone Aug 27, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@osma osma marked this pull request as ready for review August 27, 2025 13:09
@osma osma requested a review from joelit August 27, 2025 13:12
@osma osma moved this to Needs review in Skosmos 3.x Backlog Aug 27, 2025
joelit
joelit requested changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! This would also be a golden opportunity to streamline the new and deprecated configuration parameters into one - now it's two separate boolean properties skosmos:showChangeList & skosmos:showDeprecatedChanges where the former has to be set to true if the latter is to be used.

Would it be more concise if it was skosmos:showChangeList "new|new and deprecated|false"? Then again, the clear naming convention is not straight forwad and it's possible the current way is better.

@osma
Copy link
Member Author

osma commented Aug 28, 2025

now it's two separate boolean properties skosmos:showChangeList & skosmos:showDeprecatedChanges where the former has to be set to true if the latter is to be used.

This is no longer the case with Skosmos 3. showChangeList has been dropped in PR #1493 and the last remnants were cleaned up in this PR. Instead, the visible tabs are specified using sidebarViews.

showDeprecatedChanges still exists and controls whether deprecations are shown in the changes tab as well, as in Skosmos 2.

@osma osma merged commit c05f410 into main Aug 28, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Issue/PR closed in Skosmos 3.x Backlog Aug 28, 2025
@osma osma deleted the issue1793-skosmos3-configuration-overhaul branch August 28, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joelit joelit joelit approved these changes

Assignees

@osma osma

Labels

maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance

Projects

None yet

Milestone

3.0-beta.1

Development

Successfully merging this pull request may close these issues.

Skosmos 3.0 configuration property overhaul

2 participants

@osma @joelit