Reimplement sidebar tabs and their configuration#1493
Merged
UnniKohonen merged 8 commits intoskosmos-3from Aug 31, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## skosmos-3 #1493 +/- ##
===============================================
+ Coverage 70.05% 70.14% +0.09%
- Complexity 1641 1642 +1
===============================================
Files 32 32
Lines 4301 4314 +13
===============================================
+ Hits 3013 3026 +13
Misses 1288 1288
☔ View full report in Codecov by Sentry. |
joelit
requested changes
Aug 30, 2023
Contributor
There was a problem hiding this comment.
Looks good in general. Couple of situations turned up in testing that might need to be addressed.
- If you write nonsense in the configuration
skosmos:sidebarViews ( "alphabetical" "hierarchy" "dog" ) ;
Skosmos creates sidebar tabs after these - should the invalid configuration strings just be ignored instead?- IMO this should be fixed in code
- What should Skosmsos do in the situation where there is a confict between the sidebar views and the defaultConceptSidebarView:
skosmos:defaultConceptSidebarView "hierarchy" ;
skosmos:sidebarViews ( "alphabetical" "groups" ) ;
Currently this results in behaviour where the vocab page shows those two tabs as it should, but visiting a concept URL directly results in a sidebar that has the configured two tabs, but no content in the sidebar.- This could be addressed in code so that Skosmos shows a default concept sidebar if the configuration parameter is not reproduceable, or it could be just mentioned in the (upcoming) Skosmos 3.0 configuration documentation
Contributor
Author
|
I changed the config to deal with inconsistencies:
|
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Reimplementing sidebar and its configuration.
Link to relevant issue(s), if any
Description of the changes in this PR
fullAlphabeticalIndex,showAlphabeticalIndexandshowChangeListsidebarViewswhich sets available sidebar tabs for a vocabulary (given as an ordered list with possible valueshierarchy,alphabetical,fullalphabetical,groupsandchanges)defaultConceptSidebarViewwhich sets default view on concept pageKnown problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)