Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
============================================
+ Coverage 70.90% 70.94% +0.04%
- Complexity 1650 1651 +1
============================================
Files 33 33
Lines 4330 4330
============================================
+ Hits 3070 3072 +2
+ Misses 1260 1258 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0cb3322 to
a308ba2
Compare
|
|
Rebased the branch to main in order to allow automatic merging |
osma
left a comment
There was a problem hiding this comment.
I gave a few suggestions for minor code adjustments.
Looking at the search result page, I see several layout issues. The spacing between the icons and the text is sometimes nonexistent, and there are sometimes extra spaces before commas:
But this is not consistent as sometimes the result items are rendered just fine:
|
OK, the inconsistency of the search results for search result property label spacing and property value spacing is pretty weird, and probably has further implications for the consistency of the twig template. I'll track this down to the root cause. |
osma
left a comment
There was a problem hiding this comment.
A couple of issues still need fixing:
- The spacing between icons and text on the search results page is still a bit erratic
- SonarCloud complains about unnecessary escape characters
dac6433 to
47f0fca
Compare
|
UnniKohonen
left a comment
There was a problem hiding this comment.
Otherwise looks good to me, but there seems to be one unused CSS rule.
Also, IMO, the fontsize of preflabel links is too small, compare this PR (1) to the mockup layout (2). The same issue is also present on the vocab search result page.
1 
2 
|
Reasons for creating this PR
Link to relevant issue(s), if any
Description of the changes in this PR
[Skosmos-home]/en/search?clang=en&q=kissaKnown problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)