Reorganized the usage of the main element in vocabulary search page#1756
Merged
Reorganized the usage of the main element in vocabulary search page#1756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
=========================================
Coverage 70.94% 70.94%
Complexity 1650 1650
=========================================
Files 33 33
Lines 4330 4330
=========================================
Hits 3072 3072
Misses 1258 1258 ☔ View full report in Codecov by Sentry. |
osma
reviewed
Jan 29, 2025
osma
reviewed
Jan 29, 2025
Contributor
Author
|
Ok, this contains now the major refactoring of the page type classes. They are all checked against the visual spec. Now, all that remains is to resolve the inevitable conflcts with the responsive layout commits. |
… font sixes in rems instead of pixels
94f2ade to
149654b
Compare
osma
reviewed
Jan 30, 2025
osma
reviewed
Jan 30, 2025
osma
reviewed
Jan 30, 2025
osma
reviewed
Jan 30, 2025
|
osma
approved these changes
Jan 30, 2025
Member
osma
left a comment
There was a problem hiding this comment.
LGTM. It's likely that something broke but I couldn't find it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Vocabulary search page was mis-using the main element, causing there to be a duplicate structure:
This could be further refactored by using the values of the pageType variable as the CSS classes for different page styles. PageTypes are:
This PR makes the following changes:
Description of the changes in this PR
Known problems or uncertainties in this PR
None
Checklist
.sr-onlyclass, color contrast)