Merged
Conversation
joelit
requested changes
Dec 19, 2024
Contributor
joelit
left a comment
There was a problem hiding this comment.
Just two minor things to tweak and this is good to go!
| // Check that children are hidden | ||
| cy.get('#groups-list li ul').should('not.exist') | ||
| }) | ||
| it('Loads members on group click', () => { |
Contributor
There was a problem hiding this comment.
This is a redundant test that checks the sub-condition of the previous test. I'd say remove it for better maintainability.
Contributor
Author
There was a problem hiding this comment.
In the previous test, we are testing clicks on the triangle button and in this test we are testing clicks on actual group link, so they are testing slightly different things
Contributor
There was a problem hiding this comment.
Ok, in that case I take back my comment!
Co-authored-by: joelit <joeli.takala@helsinki.fi>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Groups component does not currently have any Cypress tests, this PR adds them.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 6 in #1704
Checklist
.sr-onlyclass, color contrast)