Avoid introducing extra whitespace around literal values on the concept page#1330
Merged
Avoid introducing extra whitespace around literal values on the concept page#1330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
=========================================
Coverage 70.68% 70.68%
Complexity 1646 1646
=========================================
Files 32 32
Lines 3786 3786
=========================================
Hits 2676 2676
Misses 1110 1110 Continue to review full report at Codecov.
|
b09178b to
3bcdb04
Compare
3bcdb04 to
957ad52
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
After changes made in #1317, there is now some extra whitespace around literal property values (e.g. scope notes) shown on the concept page. This happened when a Twig single-line expression was broken up for readability. The extra whitespace causes problems e.g. when copying and pasting values.
This PR simply adds
-modifiers to the Twigiftags, swallowing the extra whitespace around.(reported by @kouralex who also assisted with the proper fix)
Link to relevant issue(s), if any
Description of the changes in this PR
-modifiers to Twig tags to swallow unnecessary whitespaceKnown problems or uncertainties in this PR
None, but probably more fixes like this would be appropriate.
Checklist
.sr-onlyclass, color contrast)