Conversation
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
============================================
+ Coverage 70.36% 70.68% +0.31%
+ Complexity 1649 1646 -3
============================================
Files 32 32
Lines 3790 3786 -4
============================================
+ Hits 2667 2676 +9
+ Misses 1123 1110 -13
Continue to review full report at Codecov.
|
Contributor
Author
|
Rebased and force-pushed. Draft-PR to get test a coverage report. |
osma
requested changes
May 4, 2022
Member
osma
left a comment
There was a problem hiding this comment.
I tested this with a small snippet of DiGA and it seems to work fine!
- Please make sure the
alttags are translated, as indicated in the comments. - Please rename the PR so it has a more human-friendly title.
Other than these, looks very good to me!
|
SonarCloud Quality Gate failed.
|
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
SKOS-XL tooltips worked only partially; there was a duplicate functionality, which meant that in some parts Skosmos could show only literal values for SKOS-XL tooltips.
Link to relevant issue(s), if any
Description of the changes in this PR
Removed the duplicate functionality. Now also IRI values are displayed in SKOS-XL tooltips.
Known problems or uncertainties in this PR
None.
Checklist