Better enforce "don't export to grid" constraints#550
Merged
Conversation
…d. First - pull adjustments out of else-if chain to ensure they are applied consistently. This also helps increase charging targets in price signals dispatch. Second, adjust the custom dispatch targets if they are too high, reducing iteration. Adjust tests as needed
Collaborator
Author
|
Companion SAM PR: NatLabRockies/SAM#561 |
dguittet
approved these changes
Mar 17, 2021
Collaborator
|
@brtietz There was a failing test-- did you check that? |
Collaborator
Author
|
No, I didn't spot it until after I merged it into patch. Fix went directly to patch: fdb3272 Price signals has some minor differences running between Windows and Linux, I haven't had time to debug it yet. |
sjanzou
added a commit
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes: First - pull adjustments out of else-if chain to ensure they are applied consistently. This also helps increase charging targets in price signals dispatch. Second, adjust the custom dispatch targets if they are too high, reducing iteration. Adjust tests as needed