Fix: iec61853 module model errors#315
Merged
janinefreeman merged 4 commits intoDec 7, 2019
Merged
Conversation
added 4 commits
October 14, 2019 16:11
…oach was ported from pvwatts_v5
…effects for sky and ground diffuse irradiance components
Collaborator
|
Great, thanks for fixing those errors! I'll take a look at these. |
janinefreeman
left a comment
Collaborator
There was a problem hiding this comment.
@caseyzak24 thank you so much for this pull request! Good catch on an equation error, and adding diffuse cover effects makes sense for this model. One quick question from a code re-use perspective that I'd like your opinion on, but after that I'll integrate this for our next release.
janinefreeman
pushed a commit
that referenced
this pull request
Dec 7, 2019
…tion of sky and ground diffuse IAM effects in the IEC-61853 module model reduces expected power from those models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a handful of errors/typos in the iec61853 moduel model that were significantly affecting results and corrected them. I also changed the IAM model to consider sky and ground diffuse effects using the same approach as the cec and mlm models.