Overhaul CSP Trough UI equations and Create new IPH Trough models#1098
Merged
Conversation
…sition away from trough_equations)
Move nLoops from cmod input to output
Previous commits were not tracking IPH cmod.
… mult calculation to previous method.
…alculate m_q_design
…nk outputs. Update TOU code based on MSLF. Fix sim outputs for IPH.
sjanzou
approved these changes
Nov 30, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
All 742 ssc tests pass locally on Windows and github actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attached to PR NatLabRockies/SAM#1613