Skip to content

Overhaul CSP Trough UI equations and Create new IPH Trough models#1613

Merged
taylorbrown75 merged 42 commits into
developfrom
trough_UI_callback
Nov 30, 2023
Merged

Overhaul CSP Trough UI equations and Create new IPH Trough models#1613
taylorbrown75 merged 42 commits into
developfrom
trough_UI_callback

Conversation

@taylorbrown75

Copy link
Copy Markdown
Collaborator

Description

The CSP physical trough model has been updated to remove any UI equations and cmod intermediate equations to help facilitate scripting. The model now follows the same process as the power tower and linear Fresnel models.

A new IPH physical trough model was created based on the updated CSP model. This synchronizes the code layout of the power tower, linear Fresnel and trough IPH models.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

taylorbrown75 and others added 30 commits October 6, 2023 09:02
Add callback to cmod from system design page.
…d max htf temp to cmod. Fix capital costs UI name

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If changes in results (shown on right side) are as expected, then all is good!
image

@taylorbrown75 taylorbrown75 merged commit a5b9d66 into develop Nov 30, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release csp concentrating solar power

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants