Merge SSC patch into develop#1033
Merged
Merged
Conversation
Need to remove some modifications in cmod_pvsamv1 - set to SAM_1366 branch
Address loss diagram issue for POA reference cell in SAM issue 1366
Fix poaDecomp divide by zero and calculate_spa for missing pressure columns
…ions to vartab to make them accessible to both functions
…V now calls battery sizing
Update deprecated Ubuntu-18.04 runner
Sg2 implementation
- Allow files that have minimum required metadata, regardless of number of columns in metadata header rows. - Add Version to list of metadata columns to support NSRDB version numbers. - Test with files from NSRDB, PVWatts API, and hand-edited to have different metadata row lengths.
"Call to undeclared function 'gettimeofday'; ISO C99 and later do not support implicit function declarations" compile error
…uplicates Throw an error if duplicate entries in the voltage table produce zero slope
Fixes MacOS compile error
…ns_for_reopt_sizing
#1021) * Add errors for length mismatch between critical load and electric load * Review and revise battery error messages. --------- Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
…ns_for_reopt_sizing
Batt functions for reopt sizing
TODO - test on Windows and regenerate pysam and test on arm64, aarch64 and amd64
Fix adjustment factor daily timeseries option
… than Windows to fail Note - no error message in Github Actions log....
…d for dispatch for apples to apples comparison of forecast error
Give price signals dispatch info about real time system power and load for dispatch for apples to apples comparison of forecast error
Remove duplicate definition of size() in adjustment factors class.
Run ssc/tes/\input_json/ssc_test_save_as_JSON_test.sam in latest SAM and generate updated json files for 'save_as_JSON_test'. Run ssc/test/input_json/TechnologyModel/pvwattsv8/generate_json.lk for all CmodPVWattsv8Test.DCACRatio* tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.