Skip to content

Fix poaDecomp divide by zero and calculate_spa for missing pressure columns#1001

Merged
sjanzou merged 3 commits into
patchfrom
SAM_1367
Mar 8, 2023
Merged

Fix poaDecomp divide by zero and calculate_spa for missing pressure columns#1001
sjanzou merged 3 commits into
patchfrom
SAM_1367

Conversation

@sjanzou

@sjanzou sjanzou commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@sjanzou sjanzou self-assigned this Mar 7, 2023
@sjanzou sjanzou linked an issue Mar 7, 2023 that may be closed by this pull request
@sjanzou

sjanzou commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator Author

Now POA calculate_spa works without pressure column and POA pyranometer works with no pressure column in POA weather file.

Project file and POA weather files with and without pressure columns in attached zip file
SAM_1367.zip

To test,

  1. pull SAM_1367 branch of ssc and patch branches of other repos.
  2. open SAM_1367.sam project file
  3. Update weather file folders to include location zip file extracted
  4. select POA_without_pressure.csv as weather file for POA_without_pressure case
  5. select POA_with_pressure.csv as weather file for POA_With_pressure case
  6. Shift+F11 to run all cases
  7. Compare results
  8. Run steps 2 through 7 in current release for comparison.

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@sjanzou sjanzou merged commit ddd00f9 into patch Mar 8, 2023
@sjanzou sjanzou deleted the SAM_1367 branch March 8, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POA Pyranometer results without pressure column

3 participants