Fix cold tank issues in the solar water heating model#1011
Merged
Conversation
cpaulgilman
added a commit
to NatLabRockies/SAM
that referenced
this pull request
Apr 19, 2023
14 tasks
cpaulgilman
approved these changes
Apr 19, 2023
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
NatLabRockies/SAM#1391 updates SAM test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes limit the tank cold node temperature to a physically realizable temperature and outputs the average instead of the final temperature of the delivered water when the tank drains during a time step.
These fixes were prompted after doing parametric analyses of the hot outlet set temperature.
Before:
After:
