Batt functions for reopt sizing#149
Merged
Merged
Conversation
added 2 commits
March 28, 2023 13:31
This was referenced May 9, 2023
dguittet
reviewed
May 9, 2023
dguittet
left a comment
Collaborator
There was a problem hiding this comment.
Would be great to have an example using this functionality
cpaulgilman
approved these changes
May 10, 2023
Collaborator
Author
I'm torn about investing into examples for now. Our code is pinned to REopt V1, and upgrading to V3 in a patch seemed like a bit much. Would it be ok to put off the example until we make a decision on migration timing? |
Collaborator
|
Sounds good! |
dguittet
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySAM functions to add new SSC REopt Post function. Also fix a few typos in the PV function documentation.
Pairs with SSC PR NatLabRockies/ssc#1022 and SAM PR NatLabRockies/SAM#1398