Skip to content

Batt functions for reopt sizing#1398

Merged
brtietz merged 3 commits into
patchfrom
batt_functions_for_reopt_sizing
May 10, 2023
Merged

Batt functions for reopt sizing#1398
brtietz merged 3 commits into
patchfrom
batt_functions_for_reopt_sizing

Conversation

@brtietz

@brtietz brtietz commented May 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Add new function Reopt_size_standalone_battery_params to assist with dGen PV and battery sizing using the battery compute module. Also update URDB Python call to version 8.

SAM equations functions for this change. Pairs with SSC PR NatLabRockies/ssc#1022 and PySAM PR NatLabRockies/pysam#149

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz requested review from cpaulgilman and dguittet May 9, 2023 20:10
This was referenced May 9, 2023
Merged
Merged
cpaulgilman
cpaulgilman approved these changes May 10, 2023
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consider making this REopt call available in the SAM UI for Standalone Battery configurations (and Generic Battery if that is possible)? That would be a separate effort and pull request for the Fall 2023 release or later.

@brtietz

brtietz commented May 10, 2023

Copy link
Copy Markdown
Collaborator Author

Do we want to consider making this REopt call available in the SAM UI for Standalone Battery configurations (and Generic Battery if that is possible)? That would be a separate effort and pull request for the Fall 2023 release or later.

That's a good idea, I'll put that on the agenda for next week.

@brtietz brtietz merged commit 8b860c7 into patch May 10, 2023
@brtietz brtietz deleted the batt_functions_for_reopt_sizing branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@dguittet dguittet dguittet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brtietz @cpaulgilman @dguittet