Skip to content

Add utility rate forecast example for new stateful cmod#119

Merged
brtietz merged 8 commits into
devfrom
cmod_utilityrateforecast
Sep 22, 2022
Merged

Add utility rate forecast example for new stateful cmod#119
brtietz merged 8 commits into
devfrom
cmod_utilityrateforecast

Conversation

@brtietz

@brtietz brtietz commented Aug 31, 2022

Copy link
Copy Markdown
Collaborator

PySAM example for new cmod utility rate forecast

What is best practice with files in docs, modules, and stubs? This work generated new files there, but I wasn't sure if they should be committed. Here's what my untracked files look like:

image

Companion PRs:
SSC: NatLabRockies/ssc#868
SAM: NatLabRockies/SAM#1144

@brtietz brtietz added the enhancement New feature or request label Aug 31, 2022
@brtietz brtietz requested a review from dguittet August 31, 2022 19:59
Add sys.SolarResource.wf_use_albedo = 0
@sjanzou

sjanzou commented Sep 1, 2022

Copy link
Copy Markdown
Collaborator

MacOS 12.5.1 Apple silicon results

python UtilityRateForecastExample.py
urdb_rate_618940545457a35a1c4097ec.json
dict_keys(['ElectricityRates', 'Lifetime', 'Controls', 'Outputs'])
((0.0,), (1.0094e-320,), (5.776622002767455e-275,), (4.005296727656348e-307,), (0.0,), (1.344974619049452e-284,), (4.00530012336606e-307,), (0.0,), (1.344974619049452e-284,), (0.0,), (0.0,), (0.0,))
970.3978152001135
8760.0
1303.3002455446654

Comment thread Examples/UtilityRateForecastExample.py Outdated
Comment thread Examples/UtilityRateForecastExample.py
@dguittet

dguittet commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

@brtietz Ah good questions about files. The RST, C and pyi files should be committed. the binaries shouldn't be and I'm not sure what tmp_stubs is from

@dguittet

dguittet commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

Also, it would be great to have a test for this new module.

@brtietz brtietz requested a review from dguittet September 21, 2022 22:24
@brtietz brtietz changed the base branch from master to dev September 21, 2022 22:24
@brtietz

brtietz commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator Author

Error if urdb7.json was unchanged:
image

Correcting the JSON file doesn't affect previous utility rate tests, and allows the new tests to pass

@brtietz brtietz merged commit 116b2ad into dev Sep 22, 2022
dguittet added a commit that referenced this pull request Dec 10, 2022
* files for pysam 2.2.4

* update build_manylinux.sh

* update tests and conda build

* update SAM_api files

* closes #89 certifi certificates in fetchresource

* fixes #94

* start v 2.3.0

* fix #69

* changes from 2021.12.2 release

* add VersionChanges.rst

* add version_differ.py

* add more release info

* update version_differ.py doc str

* correct version_differ.py with PySSC

* add python 3.10

* fix getting env variables during build and remove pandas dependency

* fix test_ResouceTools.py

* switch to manylinux2010 for Python 3.10 support

* update pysam files

* update PySAM files

* Update docs for Version 3.0.1

* close #109

* remove stubs package dependency

* removal of stubs package

* Apple Silicon and Intel Wheel

pip3 install --extra-index-url https://test.pypi.org/simple/ NREL_PySAM

* update files and test

* Add utility rate forecast example for new stateful cmod (#119)

* Add utility rate forecast example for new stateful cmod

* Update failing test_Reopt_sizing.py

Add sys.SolarResource.wf_use_albedo = 0

* some stubs changes from develop. Additional documentation for utility rate forecast script

* Additional subs files from comd_utilityrateforcast sam branches and develop

* Correct energy charge schedule fields to match number of periods in energy charge fields

* add tests and improve comments in example

Co-authored-by: sjanzou <sjanzou@gmail.com>

* PySAM documentation revisions

* update setup and tests

* update files

* update versions.rst

* update rsts

* updates for v3.0.2

* update build_manylinux.sh

* update comments

* Modifications to PySSC to handle the conventions form ssc PR 907, plus module and docs updates to match

* Pysam 116 urdb version 8 (#126)

* Add resourcetools processing for urdbv8, update examples. currently fails on ur_yearzero_usage_peaks

* Add new loadtools function to convert hourly data into monthly peaks

* Mark urdb version as depricated. Move urdbv8 to new utility rate tools library. Update examples and tests

* Fix #128 - correctly apply urdb flatdemandmonths to determine tiers

* pysam v4.0.0

* update test

* add error check to build_win.bat

* fix docs

* update cmake version

Co-authored-by: sjanzou <sjanzou@gmail.com>
Co-authored-by: sjanzou <steven@janzouconsulting.com>
Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
dguittet added a commit that referenced this pull request Feb 26, 2023
* files for pysam 2.2.4

* update build_manylinux.sh

* update tests and conda build

* update SAM_api files

* closes #89 certifi certificates in fetchresource

* fixes #94

* start v 2.3.0

* fix #69

* changes from 2021.12.2 release

* add VersionChanges.rst

* add version_differ.py

* add more release info

* update version_differ.py doc str

* correct version_differ.py with PySSC

* add python 3.10

* fix getting env variables during build and remove pandas dependency

* fix test_ResouceTools.py

* switch to manylinux2010 for Python 3.10 support

* update pysam files

* update PySAM files

* Update docs for Version 3.0.1

* close #109

* remove stubs package dependency

* removal of stubs package

* Apple Silicon and Intel Wheel

pip3 install --extra-index-url https://test.pypi.org/simple/ NREL_PySAM

* update files and test

* Add utility rate forecast example for new stateful cmod (#119)

* Add utility rate forecast example for new stateful cmod

* Update failing test_Reopt_sizing.py

Add sys.SolarResource.wf_use_albedo = 0

* some stubs changes from develop. Additional documentation for utility rate forecast script

* Additional subs files from comd_utilityrateforcast sam branches and develop

* Correct energy charge schedule fields to match number of periods in energy charge fields

* add tests and improve comments in example

Co-authored-by: sjanzou <sjanzou@gmail.com>

* PySAM documentation revisions

* update setup and tests

* update files

* update versions.rst

* update rsts

* updates for v3.0.2

* update build_manylinux.sh

* update comments

* Modifications to PySSC to handle the conventions form ssc PR 907, plus module and docs updates to match

* Pysam 116 urdb version 8 (#126)

* Add resourcetools processing for urdbv8, update examples. currently fails on ur_yearzero_usage_peaks

* Add new loadtools function to convert hourly data into monthly peaks

* Mark urdb version as depricated. Move urdbv8 to new utility rate tools library. Update examples and tests

* Fix #128 - correctly apply urdb flatdemandmonths to determine tiers

* pysam v4.0.0

* update test

* add error check to build_win.bat

* fix docs

* update cmake version

* update platform tag for manylinux2014

* update files

* Fix wind resource download in ResourceTools.py

Now that Windpower supports WIND Toolkit CSV file format, no need to convert to SRW.

* update build files

---------

Co-authored-by: sjanzou <sjanzou@gmail.com>
Co-authored-by: sjanzou <steven@janzouconsulting.com>
Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
dguittet added a commit that referenced this pull request Feb 26, 2023
* files for pysam 2.2.4

* update build_manylinux.sh

* update tests and conda build

* update SAM_api files

* closes #89 certifi certificates in fetchresource

* fixes #94

* start v 2.3.0

* fix #69

* changes from 2021.12.2 release

* add VersionChanges.rst

* add version_differ.py

* add more release info

* update version_differ.py doc str

* correct version_differ.py with PySSC

* add python 3.10

* fix getting env variables during build and remove pandas dependency

* fix test_ResouceTools.py

* switch to manylinux2010 for Python 3.10 support

* update pysam files

* update PySAM files

* Update docs for Version 3.0.1

* close #109

* remove stubs package dependency

* removal of stubs package

* Apple Silicon and Intel Wheel

pip3 install --extra-index-url https://test.pypi.org/simple/ NREL_PySAM

* update files and test

* Add utility rate forecast example for new stateful cmod (#119)

* Add utility rate forecast example for new stateful cmod

* Update failing test_Reopt_sizing.py

Add sys.SolarResource.wf_use_albedo = 0

* some stubs changes from develop. Additional documentation for utility rate forecast script

* Additional subs files from comd_utilityrateforcast sam branches and develop

* Correct energy charge schedule fields to match number of periods in energy charge fields

* add tests and improve comments in example

Co-authored-by: sjanzou <sjanzou@gmail.com>

* PySAM documentation revisions

* update setup and tests

* update files

* update versions.rst

* update rsts

* updates for v3.0.2

* update build_manylinux.sh

* update comments

* Modifications to PySSC to handle the conventions form ssc PR 907, plus module and docs updates to match

* Pysam 116 urdb version 8 (#126)

* Add resourcetools processing for urdbv8, update examples. currently fails on ur_yearzero_usage_peaks

* Add new loadtools function to convert hourly data into monthly peaks

* Mark urdb version as depricated. Move urdbv8 to new utility rate tools library. Update examples and tests

* Fix #128 - correctly apply urdb flatdemandmonths to determine tiers

* pysam v4.0.0

* update test

* add error check to build_win.bat

* fix docs

* update cmake version

* update platform tag for manylinux2014

* update files

* Fix wind resource download in ResourceTools.py

Now that Windpower supports WIND Toolkit CSV file format, no need to convert to SRW.

* Update failing test and build arm64 and aarch64 4.0.1

* twine works for arm64 wheels but manylinux1_aarch64 not supported

anaconda upload fails with 
Extracting conda package attributes for upload
Creating package "nrel-pysam"
Creating release "4.1.0"
[ERROR] ('"nrel-pysam" could not be found', 404)

---------

Co-authored-by: dguittet <dguittet@nrel.gov>
Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
@dguittet dguittet deleted the cmod_utilityrateforecast branch March 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants