Skip to content

Update SAM samples files for SAM 2021.12.02#895

Merged
cpaulgilman merged 7 commits into
patchfrom
update-sample-sam-files
Feb 8, 2022
Merged

Update SAM samples files for SAM 2021.12.02#895
cpaulgilman merged 7 commits into
patchfrom
update-sample-sam-files

Conversation

@cpaulgilman

@cpaulgilman cpaulgilman commented Jan 20, 2022

Copy link
Copy Markdown
Collaborator

Move notes for new pages from Location and Resource page.

Fix DC/AC ratio for microinverter sample file's central inverter case.

Add note about plotting independent parametrics.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 1 milestone Jan 20, 2022
@cpaulgilman cpaulgilman requested a review from sjanzou January 20, 2022 23:04
@cpaulgilman cpaulgilman self-assigned this Jan 20, 2022
sjanzou
sjanzou requested changes Jan 21, 2022
View reviewed changes

@sjanzou sjanzou left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge changes into patch first and then from patch into develop.

sample-pv-microinverters.sam - the notes work great

For parametric-quick-setup-examples.sam:

What about moving the notes from the "Location and Resource" page to the parametrics page and having a note to click "Parametrics" on the "Location and Resource" page?

Now when I open the sample file:
image

and the parametrics page has no notes
image

Brian Mirletz and others added 7 commits January 24, 2022 16:50
@cpaulgilman
change default branch to develop for GitHub actions
dbec05f
@cpaulgilman
Update README.md
b7d45f5
@cpaulgilman
update reference citation
ccd4ff0
@dguittet @cpaulgilman
add printing for Models.rst and Configs.rst
6ac0ab8
@cpaulgilman
Add sco2 python yml (#879)
6eafae9 
* add yml to build python environment for sco2 code

* update sco2 user guide for new yml
@cpaulgilman
Update SAM samples files for SAM 2021.12.02
143f75d 
Move notes for new pages from Location and Resource page.

Fix DC/AC ratio for microinverter sample file's central inverter case.

Add note about plotting independent parametrics.
@cpaulgilman
Move notes to parametrics page
518e8f6
@cpaulgilman cpaulgilman force-pushed the update-sample-sam-files branch from b938000 to 518e8f6 Compare January 25, 2022 00:50
@cpaulgilman cpaulgilman changed the base branch from develop to patch January 25, 2022 00:51
@cpaulgilman

cpaulgilman commented Jan 25, 2022

Copy link
Copy Markdown
Collaborator Author

@sjanzou Thanks for the review: This PR should be off of Patch now. I moved the notes as you suggested.

@cpaulgilman cpaulgilman requested a review from sjanzou February 2, 2022 16:05
sjanzou
sjanzou approved these changes Feb 3, 2022
View reviewed changes

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpaulgilman , the parametrics sample file notes are still opening on the Location and Resource page and not the parametrics page for me...
image

Not a big deal and I do not want to hold up this pull request so I am approving.

@cpaulgilman cpaulgilman merged commit 00ebbcb into patch Feb 8, 2022
dguittet added a commit that referenced this pull request Feb 10, 2022
@dguittet @cpaulgilman
Automate ssc diff develop (#932)
dda8856 
* test in ci.yml

* fix python requirements.txt

* python version 3.7

* fix semantic

* print path out

* fix upload artefact path

* restore commented out ci.yml steps

* upload linux test results as Artefact

* Update SAM samples files for SAM 2021.12.02 (#895)

* change default branch to develop for GitHub actions

* Update README.md

* update reference citation

* add printing for Models.rst and Configs.rst

* Add sco2 python yml (#879)

* add yml to build python environment for sco2 code

* update sco2 user guide for new yml

* Update SAM samples files for SAM 2021.12.02

Move notes for new pages from Location and Resource page.

Fix DC/AC ratio for microinverter sample file's central inverter case.

Add note about plotting independent parametrics.

* Move notes to parametrics page

Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: dguittet <dguittet@nrel.gov>
Co-authored-by: tyneises <ty.neises@nrel.gov>

* revert default checkout branch back to patch

* move python setup earlier in ci.yml

Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: tyneises <ty.neises@nrel.gov>
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
@cpaulgilman cpaulgilman deleted the update-sample-sam-files branch October 20, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjanzou sjanzou sjanzou approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Milestone

2021.12.02 Patch 1

Development

Successfully merging this pull request may close these issues.

3 participants

@cpaulgilman @sjanzou @dguittet