Skip to content

Fix SAM 857 and 875#889

Merged
brtietz merged 2 commits into
patchfrom
fix_sam_857_and_875
Jan 20, 2022
Merged

Fix SAM 857 and 875#889
brtietz merged 2 commits into
patchfrom
fix_sam_857_and_875

Conversation

@brtietz

@brtietz brtietz commented Jan 19, 2022

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

GUI changes related to SSC PR NatLabRockies/ssc#723. Enable/disable billing demand periods table based on values of both ur_enable_billing_demand and ur_dc_enable

Fixes #857 and #875

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • [ x] Any dependent changes have been merged and published in downstream modules
  • [x ] I have checked my code and corrected any misspellings

@brtietz brtietz added this to the 2021.12.02 Patch 1 milestone Jan 19, 2022
@brtietz brtietz requested a review from cpaulgilman January 19, 2022 19:05
@brtietz brtietz mentioned this pull request Jan 19, 2022
Merged
This was linked to issues Jan 19, 2022
SAM crashes when provided a kWh/kW rate in only some months #857
Closed
Invalid energy charge table with different numbers of tiers causes exec fail #875
Closed
@cpaulgilman

cpaulgilman commented Jan 20, 2022

Copy link
Copy Markdown
Collaborator

@brtietz Do you agree with changing the divider label "Billing Demand by Time-of-use Period" to "Billing Demand by Time-of-use Period for Demand Charges?" Enabling the table only when demand charges are enabled and the text next to the table are helpful, but perhaps not enough to most clearly communicate that those TOU periods are not energy charge TOU periods.

image

@brtietz

brtietz commented Jan 20, 2022

Copy link
Copy Markdown
Collaborator Author

Good thinking. Fixed in latest push.

@brtietz brtietz merged commit 02d4263 into patch Jan 20, 2022
This was referenced Jan 20, 2022
Closed
Closed
@brtietz brtietz deleted the fix_sam_857_and_875 branch January 28, 2022 23:17
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

No one assigned

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug utility rate

Projects

None yet

Milestone

2021.12.02 Patch 1

Development

Successfully merging this pull request may close these issues.

Invalid energy charge table with different numbers of tiers causes exec fail SAM crashes when provided a kWh/kW rate in only some months

2 participants

@brtietz @cpaulgilman