Fix broken code generation to test broken peak shaving#708
Merged
Conversation
Collaborator
|
When testing with the default pv-battery commercial case and trying to export PySAM JSON, I get this:
However, this was against the connect_outage_vars_to_powerflow branch on SSC. Is the Fix_issues branch with the change to batt_annual_charge_energy required for that to work? |
sjanzou
added a commit
to sjanzou/SAM
that referenced
this pull request
Sep 29, 2021
brtietz
approved these changes
Sep 29, 2021
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Latest version looks great, thanks!
This was referenced Oct 9, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.