Fix Stochastic UI Issues#565
Merged
Merged
Conversation
These changes address items in #22 * Improve widget labels to make weather file distribution option clearer. * Convert Show CDF from message box to grid to enable copying and pasting.
* On the Location and Resource UI form, clear the Calculated and Indicator check boxes for solar_resource_file, and change the label for solar_resource from "Location" to "Solar resource library current selection". Change background and foreground properties of UI widget to make it look like a calculated value. * Show generated samples table when user clicks Run simulations unless they clicked Compute samples without changing inputs, correlations, or outputs.
sjanzou
reviewed
Mar 24, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Not sure if you wanted to change the Solar Resource Data UI form in this pull request. Great job with the tables!
sjanzou
requested changes
Mar 30, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Can we leave the test_results_win64.csv out?
| PV Battery,All Equity Partnership Flip,92853616,9.339340,10.855825,; | ||
| PV Battery,Sale Leaseback,92853616,9.509975,9.770243,; | ||
| PVWatts Battery,Residential,8022.540527,11.707731,NA,; | ||
| PV Battery,Single Owner,92853624,7.822259,9.770245,; |
Collaborator
There was a problem hiding this comment.
Not sure why these are changing... do the results need to be updated?
Collaborator
…AM22_stochastic
…ranches with the same names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564 -- See issue for what to test