Lcos cost inputs#529
Merged
Merged
Conversation
variable names for more clarity
sjanzou
requested changes
Feb 9, 2021
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
The tests are failing - most likely due to the default changes. Can you run all the default configurations and check test_results_win64.csv for valid results and then commit and push those results for Travis to match?
cpaulgilman
requested changes
May 4, 2021
Collaborator
There was a problem hiding this comment.
Layout of new O&M cost inputs looks nice.
- Be sure to add/update UI group name so inputs appear in groups with other related variables in lists for LK script editor, parametrics, etc.
-
I think I would prefer these UI forms to be named "O and M Costs PV", "O and M Costs Fuel Cell", etc. so they appear together in the IDE to make them easier to find when working on these O&M input variables.
-
Cash flow tab is showing "not found" for several items under "LCOS CALCULATIONS".
cashflow for correct output variable names
cpaulgilman
reviewed
Jun 18, 2021
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
I'm getting these messages when I create a new PV Battery / Single Owner case:
No default value found for 'wf_nrecords' in external file (PV Battery/Single Owner), using internal default
No default value found for 'vdcmax_inverter' in external file (PV Battery/Single Owner), using internal default
Defaults file is likely out of date: PV Battery_Single Owner.txt
Variables: 1 loaded but not in configuration, 0 wrong type, defaults file has 1130, config has 1131
Would you like to update the defaults with the current values right now?
(Otherwise press Shift-F10 later)
Loaded but don't exist in config: ui_batt_is_dc
cpaulgilman
approved these changes
Jul 1, 2021
Closed
cpaulgilman
added a commit
that referenced
this pull request
Feb 17, 2022
Revise description of load data time convention. Remove O&M cost content from Installation Costs topics. Add ETES topics and fix broken help links. Fix typo on battery storage FOM "BTM" insteasd of "FOM" Wind resource files can now be .csv in addition to .srw Revise capacity factor descriptions for PV and Battery storage configs, #905 Wave resource instructions for converting from time series to JPD, #892 Revise PV land area calculations to account for GCR and tilt angle, #928 Add pvlib column headings to SAM CSV format description, NatLabRockies/ssc#754 Revised Operating Cost input pages Check for "annual energy" vs new "electricity to grid". Change "battery autonomy" to "autonomy". Revise power tower heliostat field to better explain how check box vs button works. Add note for degradation by year that Year 1 value should be zero, #755 Remove debt from payback period description. Also remove detailed cash flow descriptions and replace with mention of send-to-Excel with equations and spreadsheets on website. See Amir Nashed email 1/19/21 and https://sam.nrel.gov/forum/forum-general/1052 Revise Electricity Purchases page to be specific for FOM projects New LCOS metrics: #529 Electricity rates revisions from Brian. Reporting of electricity bill in time series results, see NatLabRockies/ssc#652 New parametrics features Parametrics description of how to work with SchedNumeric variables like PPA price. See Brian email 7/21/2021 Update Heliostat Field per #717 New PV slope inputs on System Design page. See #742, NatLabRockies/ssc#648 New "Limit debt fraction" Input on Financial Parameters page for PPA models New ETES model. Fix outdated description of NSRDB in Location and Resource topic UDPC updates from Ty, see Revisions 2021 folder. Also post new PDF version of Ty and Matt's description under "CSP Power Cycle Models" on SAM website https://sam.nrel.gov/concentrating-solar-power/csp-publications.html, https://sam.nrel.gov/images/web_page_files/Neises-DRAFT-user-defined-power-cycle-v3-2018.pdf Fix excess generation descriptions in help: https://sam.nrel.gov/forum/forum-general/3485. Also maybe change "Excess generation" to "Excess generation for net metering" or similar. Note for URDB download that demand ratchet data in URDB is unreliable, so check with data sheet. Demand charges with ratcheting lookback months. See Revision Notes mirletz-RE Adding billing demand lookback to SAM.msg, see [[F:\OneDrive\SAM\Utility Rates\Demand Ratchets\Initial Tests May 2021]] Update pv smoothing per Steve's email 12/9/2021 "pv smoothing question" Improve description of FOM automated dispatch. See https://sam.nrel.gov/forum/forum-general/3681 Revise electricity rates page Consolidate weekday/weekend schedule descriptions. SWH remove old hot water draw import instructions. Revise electricity purchases PPA price option not available with Specify IRR target, and purchases treated as tax-deductible operating expense. Move electricity purchases page to from Battery section to Electricity Rates and Load section Edit Lifetime Data add note about pasting data from Excel: Thousands comma separator causes paste not to work correctly, e.g, 1,000 is pasted as 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-New PV+Battery OM cost UI form with updated variable names for financial models
-New storage salvage value input that still needs to be workshopped
-Labels still up for changing for OM cost definitions based on industry standards
-Changes to cashflow to include LCOS cash flows