Skip to content

Ssc 1300 wind lifetime mode#2174

Merged
brtietz merged 38 commits into
ssc_1378_custom_generation_lifetimefrom
ssc_1300_wind_lifetime_mode
May 7, 2026
Merged

Ssc 1300 wind lifetime mode#2174
brtietz merged 38 commits into
ssc_1378_custom_generation_lifetimefrom
ssc_1300_wind_lifetime_mode

Conversation

@brtietz

@brtietz brtietz commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

GUI and defaults changes to fix NatLabRockies/ssc#1300

Merging into the generic system lifetime mode branch. Want to review the wind changes alone for now. Specifically: this does not touch the hybrids yet, that will be handled in a future PR before this all hits develop. Version upgrade throws errors for hybrids until this is fixed.

Corresponding branches and PRs:

SSC branch ssc_1300_wind_lifetime_mode, develop for others.

SSC PR: NatLabRockies/ssc#1386

Unit Test Impact:

Expect wind to be slower in lifetime weather file mode (the default here). Please discuss on the SSC PR as needed.

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

cpaulgilman and others added 17 commits April 13, 2026 08:22
Remove data validation in Inputs!C34.

Multiply major equipment reserve account by 1000 W/kW in Inputs!D96, D97, D98. Also fix in host developer, merchant plant, partnership flip, sale leaseback, and single owner spreadsheets. Note this only affects value on Inputs sheet.  Cash flow value is correctly calculated on Cash Flow sheet.

Fix unsubscribed share Inputs!C37: "=100-SUM(subscriber1_share,subscriber2_share,subscriber3_share,subscriber4_share)".
Set Pxx value to unsigned, limit to 1-99
…d given new degradation default. Not sure why CSP changed

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjanzou Thanks for cleaning up the version upgrade script! Do you mind doing one more pass of comment cleanup for clarity? I flagged two spots in the code where I was confused.

Comment thread src/project.cpp Outdated
Comment thread src/project.cpp Outdated

@mjprilliman mjprilliman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the on_load that was causing the warning message to show up all the time. For some reason typing 0.64 and shift+f10 avoids extra digits from defaults manager, probably something to investigate in more detail later. Results look as expected.

Image

@brtietz brtietz merged commit 5ee79e7 into ssc_1378_custom_generation_lifetime May 7, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants