Conversation
berg-michael
reviewed
Jun 3, 2025
berg-michael
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good to me and align with those made in SAM #1856.
There are a few other places where we use PrettyWriter. Most have the kWriteNanAndInfFlag set, but InputPageData::Write_JSON in src/main.cpp and WritePythonConfig in src/pythonhandler.cpp do not.
I'm not familiar with the type of data that'd be written by those functions. Is is possible that there would be NaNs/Infs? If so, I think those should be changed as well.
Otherwise, I have no comments.
Collaborator
Author
|
Go through remaining occurrences of PrettyWriter and update all with NaN and Inf flag and create ssc pull request NatLabRockies/ssc#1333 to go with SAM #2086 |
brtietz
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2085