Skip to content

Fix PV time series shading#1712

Merged
cpaulgilman merged 3 commits into
patchfrom
3d-shade-callback-error
Feb 27, 2024
Merged

Fix PV time series shading#1712
cpaulgilman merged 3 commits into
patchfrom
3d-shade-callback-error

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

This fixes #1427 and #1678

  • Time series shading data should be correctly applied by 3D shade calculator for Detailed PV with up to 4 subarrays and 8 strings, and for PVWatts.

  • PVWatts shading data window should not show labels for strings/number of strings, and should not automatically select shading database option when time series data is imported or pasted.

File for testing: 3d-shade-test.zip

To Test:

  1. Open .sam test file.
  2. For each case, open 3D shade calculator and click Save and Close and then click Yes to apply shading data.
  3. Click Edit shading to verify that shade data is applied to time series beam shading table and diffuse.
  4. For PVWatts note overlapping labels are gone.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Hide "Strings in subarray" label and listbox for PVWatts
@cpaulgilman cpaulgilman added the UI User interface issue that applies across performance and financial models label Feb 26, 2024
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Feb 26, 2024
@cpaulgilman cpaulgilman self-assigned this Feb 26, 2024

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "holy potato" case had and interesting shading scene
image

The diffuse shading edit box is a little small for all the significant figures
image

The loss diagram for the "holy potato" case was interesting
image

PVWatts case looks good without the "Strings in Subarray: [n]" entry.
image

Adjust size of 3d shade calculator window so "Save and close" is visible.
@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

The loss diagram for the "holy potato" case was interesting

For the shading database option, the beam shading loss is a DC loss, so is represented in the loss diagram in the "Module deviation from STC" category.

There's a discussion about this here: NatLabRockies/ssc#205

The diffuse shading edit box is a little small for all the significant figures

I fixed that in the latest commit, and also made the 3D Shade Calculator window bigger so the "Save and close" tab is visible.

@cpaulgilman cpaulgilman merged commit 9debef4 into patch Feb 27, 2024
@cpaulgilman cpaulgilman deleted the 3d-shade-callback-error branch February 27, 2024 22:29
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code generation for c#

2 participants