Skip to content

Fix SAM #1485#1513

Merged
sjanzou merged 3 commits into
developfrom
SAM_1485
Oct 25, 2023
Merged

Fix SAM #1485#1513
sjanzou merged 3 commits into
developfrom
SAM_1485

Conversation

@sjanzou

@sjanzou sjanzou commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@sjanzou sjanzou self-assigned this Oct 22, 2023
@sjanzou sjanzou linked an issue Oct 22, 2023 that may be closed by this pull request
Results button resetting when linked hybrid variables are reloaded #1485
Closed
cpaulgilman
cpaulgilman reviewed Oct 23, 2023
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is good, but Results button requires two clicks to switch to Results page instead of one.

@sjanzou

sjanzou commented Oct 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Functionality is good, but Results button requires two clicks to switch to Results page instead of one.

I have tested on Windows 11 and RHEL 8.6 and the results button is only requiring one click for me
image

The tooltip is a nice touch!
image

MacOS is requireing the double click - stepping through now - no event changes...order fixed in latest commit.

@mjprilliman , @brtietz - how many clicks is the results button requiring for you to go to the results page from an input page?

@sjanzou sjanzou requested a review from cpaulgilman October 24, 2023 05:59
brtietz
brtietz approved these changes Oct 24, 2023
View reviewed changes

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me with one click

@mjprilliman mjprilliman removed their request for review October 24, 2023 22:33
cpaulgilman
cpaulgilman approved these changes Oct 25, 2023
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Mac with single click.

@sjanzou sjanzou merged commit 4a1c940 into develop Oct 25, 2023
@sjanzou sjanzou deleted the SAM_1485 branch October 25, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brtietz brtietz brtietz approved these changes

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

@sjanzou sjanzou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Results button resetting when linked hybrid variables are reloaded

3 participants

@sjanzou @brtietz @cpaulgilman