Skip to content

Fix PV sizing message logic#1376

Merged
cpaulgilman merged 1 commit into
patchfrom
pv-sizing-message
Mar 23, 2023
Merged

Fix PV sizing message logic#1376
cpaulgilman merged 1 commit into
patchfrom
pv-sizing-message

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Fix logic for PV sizing message (layout_warning) on PV System Design page.

Fixes #1373

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2022.11.21 Patch 2 milestone Mar 16, 2023
@cpaulgilman cpaulgilman requested a review from mjprilliman March 16, 2023 22:26
@cpaulgilman cpaulgilman merged commit e9ff32a into patch Mar 23, 2023
@cpaulgilman cpaulgilman deleted the pv-sizing-message branch March 23, 2023 21:24
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV System Design page sizing message incorrect

2 participants