Skip to content

Quackery#1283

Merged
cpaulgilman merged 4 commits into
developfrom
quackery
Nov 19, 2022
Merged

Quackery#1283
cpaulgilman merged 4 commits into
developfrom
quackery

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Add duck curve TOD factors to library for PPA financial models, and add descriptions of TOD library items to "PPA Revenue" Help topic.

This does not affect any defaults, it just adds new choices to the CSV library file.

Fixes #1119

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Nov 18, 2022
@cpaulgilman cpaulgilman self-assigned this Nov 18, 2022

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New schedules quack like a duck, but it looks like there was a line break issue with PG&E 2016 schedule:

image

Comment thread deploy/libraries/TOD Schedules and Factors.csv Outdated
@cpaulgilman cpaulgilman requested a review from brtietz November 18, 2022 18:40

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@cpaulgilman cpaulgilman merged commit 251eba6 into develop Nov 19, 2022
@cpaulgilman cpaulgilman deleted the quackery branch November 19, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "duck curve" schedule for TOD PPA price multiplier

2 participants