Skip to content

Check whether bifacial electrical mismatch should be enabled on calculate option change#1282

Merged
mjprilliman merged 1 commit into
developfrom
bifacial_elec_mismatch_enable
Nov 18, 2022
Merged

Check whether bifacial electrical mismatch should be enabled on calculate option change#1282
mjprilliman merged 1 commit into
developfrom
bifacial_elec_mismatch_enable

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Add on change function call to enable/disable bifacial electrical mismatch loss input rather than just on page load

Fixes #1281

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added bug pv pvsam1, pvwatts, hcpv labels Nov 18, 2022
@mjprilliman mjprilliman added this to the SAM Fall 2022 Release milestone Nov 18, 2022
@mjprilliman mjprilliman self-assigned this Nov 18, 2022

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mjprilliman mjprilliman merged commit 9373ec4 into develop Nov 18, 2022
@mjprilliman mjprilliman deleted the bifacial_elec_mismatch_enable branch November 18, 2022 18:42
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
@Matthew-Boyd

Copy link
Copy Markdown
Contributor

I'm a little late, but thanks Matt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable/disable bifacial electrical mismatch

4 participants