Skip to content

Land area calculations#1166

Merged
mjprilliman merged 2 commits into
developfrom
sam-1143-fix
Oct 12, 2022
Merged

Land area calculations#1166
mjprilliman merged 2 commits into
developfrom
sam-1143-fix

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

Description

-Removed gcr dependence on PVWatts module area (module area rather than project area)
-Added row of space in front of first row and back of last row
-acre/MWac aligns well with https://www.nrel.gov/docs/fy13osti/56290.pdf
-8.5 acre/MWac in SAM, 8.3-9.0 in report (8.3 total land area, 9.0 direct land area for different samples)

Fixes #1143

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

front of back of PV arrays for alignment with studied acre/MWac results
@mjprilliman mjprilliman added bug pv pvsam1, pvwatts, hcpv labels Sep 30, 2022
@mjprilliman mjprilliman added this to the SAM Fall 2022 Release milestone Sep 30, 2022
@mjprilliman mjprilliman self-assigned this Sep 30, 2022

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that these are consistent now!

The language under land area estimate needs to be updated now that the dependency on tilt has been removed:

image

@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Oct 4, 2022

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Detailed PV and PVWatts Single Owner now give consistent results for the same DC capacity as GCR, land area multiplier, and additional land area changes.

@mjprilliman

Copy link
Copy Markdown
Collaborator Author

Merging this and making the acre/MW input a separate issue to be considered for this release/ a future patch.

@mjprilliman mjprilliman merged commit e5e3e1e into develop Oct 12, 2022
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Oct 28, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug pv pvsam1, pvwatts, hcpv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update land use calculations for consistency and industry rules of thumb

3 participants