Update nameplate capacity for standalone battery systems#1040
Merged
Conversation
system_capacity for standalone battery to AC for CBI?
brtietz
approved these changes
May 13, 2022
Collaborator
|
I agree with Brian: For PV-Battery and Generic-Battery, the variable label should be Battery maximum discharge power, MWac, and the last sentence of the UI text should be revised to read "The battery maximum discharge power is shown here for reference only." You can move the label about inflation to the left to make room. Also, for the Standalone Battery configuration, I think the variable labels are likely to overlap on Mac and Linux, so maybe move the capacity payment amount and capacity payment escalation to the left to allow more vertical space between the variables. |
show/hide of variables for batt and system capacity
* Label change to "Battery maximum discharge power" * Format system nameplate calculated value to fixed with 3 decimals. * Edit description to change label to battery maximum discharge power. * Adjust vertical spacing between input boxes to be consistent with rest of UI.
cpaulgilman
approved these changes
May 18, 2022
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good after my final tweaks to the UI.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
-Change capacity nameplate (system_capacity) to maximum discharge power AC for standalone battery systems
-Affects basis for CBI calculations
-Adds ui variable to defaults for capacity payments
Fixes #1036
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.