Skip to content

Fix issues with CSP custom HTF#1006

Merged
cpaulgilman merged 2 commits into
patchfrom
custom-htf
Apr 18, 2022
Merged

Fix issues with CSP custom HTF#1006
cpaulgilman merged 2 commits into
patchfrom
custom-htf

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

Disable Edit button unless HTF selection is "user-defined:"

  • Make sure the UIObject property for all instances of MaterialProperties widgets is set to MaterialProperties instead of Default.

  • Disable MaterialProperties "Edit" button unless HTF option is set to "User-defined."

Fixes #964

Goes with NatLabRockies/ssc#788

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [x ] I have checked my code and corrected any misspellings

Make sure the UIObject property for all instances of MaterialProperties widgets is set to MaterialProperties instead of Default.

Disable MaterialProperties "Edit" button unless HTF option is set to "User-defined" for all CSP configurations that use widget.
@cpaulgilman cpaulgilman requested a review from tyneises April 18, 2022 17:03
@cpaulgilman cpaulgilman merged commit 1affdf4 into patch Apr 18, 2022
@cpaulgilman cpaulgilman deleted the custom-htf branch April 18, 2022 20:23
@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Apr 19, 2022
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSP custom HTF widget causes unhandled exception

2 participants