Skip to content

Fix 11307 - Add null check for Schedule:Compact with missing values#11315

Merged
mitchute merged 2 commits intoNatLabRockies:developfrom
bigladder:Fix-11307-Crash-when-Schedule-Compact-missing-values
Nov 6, 2025
Merged

Fix 11307 - Add null check for Schedule:Compact with missing values#11315
mitchute merged 2 commits intoNatLabRockies:developfrom
bigladder:Fix-11307-Crash-when-Schedule-Compact-missing-values

Conversation

@kevin-moos
Copy link
Contributor

@kevin-moos kevin-moos commented Nov 3, 2025

Pull request overview

Description of the purpose of this PR

Add null check for Schedule:Compact with missing values - this will prevent the crash and ensure a Severe error is included in the output.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

" ..... Reference severe error count=2",
" ..... Last severe error=ProcessScheduleInput: Schedule:Compact = OCCSCHED"});

compare_err_stream(expected_error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so this will throw a fatal and the user must correct the schedule. This looks fine.

@kevin-moos kevin-moos marked this pull request as ready for review November 4, 2025 21:33
@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Nov 6, 2025
@mitchute
Copy link
Collaborator

mitchute commented Nov 6, 2025

Looks good. Merging.

@mitchute mitchute merged commit 0db3722 into NatLabRockies:develop Nov 6, 2025
11 of 12 checks passed
@kevin-moos kevin-moos deleted the Fix-11307-Crash-when-Schedule-Compact-missing-values branch November 6, 2025 22:55
@JasonGlazer
Copy link
Contributor

Thanks @mitchute

@JasonGlazer
Copy link
Contributor

Thanks @kevin-moos I'm glad this made it in for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when Schedule:Compact missing values

6 participants