Skip to content

Address RC1 incorrect unused object warning issue#11305

Merged
mitchute merged 1 commit intodevelopfrom
Issue11304_UnusedObjectWarning
Oct 29, 2025
Merged

Address RC1 incorrect unused object warning issue#11305
mitchute merged 1 commit intodevelopfrom
Issue11304_UnusedObjectWarning

Conversation

@Nigusse
Copy link
Contributor

@Nigusse Nigusse commented Oct 29, 2025 •
edited
Loading

Pull request overview

  • Fixes v25.2.0 RC1 incorrect unused object warning #11304
  • This warning error was introduced when the getinput method was translated into JSON input processing method for the Coil:WaterHeating:AirToWaterHeatPump:Wrapped and Coil:WaterHeating:AirToWaterHeatPump:Pumped objects.

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@Nigusse Nigusse added the Defect Includes code to repair a defect in EnergyPlus label Oct 29, 2025
rraustad
rraustad reviewed Oct 29, 2025
View reviewed changes
src/EnergyPlus/DXCoils.cc
++DXCoilNum;
auto const &fields = instance.value();
std::string const &thisObjectName = instance.key();
s_ip->markObjectAsUsed(CurrentModuleObject, thisObjectName);
Copy link
Collaborator

@rraustad rraustad Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If getObjectItem is removed, which marks the object as used, then that functionality must be restored in json processing.

rraustad
rraustad approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct fix.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit e54b206

Regression Summary
  • ERR: 6

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

⚠️ Regressions detected on macos-14 for commit e54b206

Regression Summary
  • ERR: 6

mitchute
mitchute approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good. Merging.

@mitchute mitchute merged commit cdb4481 into develop Oct 29, 2025
11 of 12 checks passed
@mitchute mitchute deleted the Issue11304_UnusedObjectWarning branch October 29, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitchute mitchute mitchute approved these changes

@rraustad rraustad rraustad approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v25.2.0 RC1 incorrect unused object warning

5 participants

@Nigusse @mitchute @rraustad @nrel-bot-2 @nrel-bot-2c