Fix zone multipliers for OA proportional control and design load per area reporting by mjwitte · Pull Request #11259 · NatLabRockies/EnergyPlus

mjwitte · 2025-10-07T22:19:31Z

Pull request overview

Fixes Incorrect accounting for zone multipliers in the Outdoor Air Details report #10799
- Add Zone Multiplier column to Outdoor Air Details report "by zone" tables.
- Fix "User Design Load per Area" in HVAC Sizing Summary table (load was multiplied but area was not).
- Fix floor area and number of occupants in eio output for "Zone Sizing Information" (load was multiplied but area and occupants were not).
Fixes double-counting of zone mulipliers for OA control types ProportionalControlBasedOnDesignOccupancy and ProportionalControlBasedOnOccupancySchedule.

Pull Request Author

Reviewer

…MultipliersAndOA

github-actions · 2025-10-07T22:48:16Z

⚠️ Regressions detected on macos-14 for commit `bae4e6c`

Regression Summary

Audit: 801
Table Big Diffs: 696
Table String Diffs: 89
EIO: 43

github-actions · 2025-10-07T22:56:02Z

⚠️ Regressions detected on ubuntu-24.04 for commit `bae4e6c`

Regression Summary

Audit: 805
Table Big Diffs: 698
Table String Diffs: 89
EIO: 43

rraustad · 2025-10-08T00:11:06Z

@mjwitte I don't see anything in these changes to comment on. Looks good so far.

mjwitte · 2025-10-08T15:42:48Z

Using example file RefBldgSmallOfficeNew2004_Chicago with 10x multipliers. Here is a sample of the new Outdoor Air Details report with new Zone Multiplier Column.

mjwitte · 2025-10-08T15:49:30Z

Using example file RefBldgSmallOfficeNew2004_Chicago with 1x vs 10x multipliers. Here's an example of the corrected "User Design Load per Area" with multipliers.

1x output (with develop and this branch):

10x output with develop (incorrect):

10x output with this branch (correct):

github-actions · 2025-10-08T15:59:47Z

⚠️ Regressions detected on ubuntu-24.04 for commit `1d98238`

Regression Summary

Audit: 805
Table Big Diffs: 698
Table String Diffs: 89
EIO: 43

mjwitte · 2025-10-08T16:01:24Z

All files with multipliers show eio diffs like this, e.g. 5ZoneSwimmingPoolZoneMultipliers.

A bit hard to see, but at the far right, for the first zone "Floor Area" and "# Occupants" were
99.16000, 11.00000 and are now 297.48000, 33.00000.

github-actions · 2025-10-08T16:02:49Z

⚠️ Regressions detected on macos-14 for commit `1d98238`

Regression Summary

Audit: 801
Table Big Diffs: 696
Table String Diffs: 89
EIO: 43

mjwitte · 2025-10-08T16:11:30Z

Zone multipliers were being double-counted for the OA proportional control options. Using example file DOAToUnitarySystem, here are the 1x and 10x outdoor air details with develop, then with this branch.

1x-develop

10x-develop - OA quantities are way more than 10x

10x-this branch - now OA quantities are 10x

mjwitte

Code walkthru

mjwitte · 2025-10-08T16:13:05Z

src/EnergyPlus/DataSizing.cc

        ZoneOAPeople = 0.0;
        if (this->OAFlowMethod != DataSizing::OAFlowCalcMethod::PCDesOcc) {
-            ZoneOAPeople = curNumOccupants * thisZone.Multiplier * thisZone.ListMultiplier * this->OAFlowPerPerson;
+            ZoneOAPeople = curNumOccupants * this->OAFlowPerPerson;


Remove multipliers in this case block, because multipliers are applied at the end for all cases.

mjwitte · 2025-10-08T16:13:34Z

src/EnergyPlus/DataSizing.cc


    // Apply zone multipliers and zone list multipliers
-    // TODO MJW: this looks like it's double-counting the multipliers - it *is* double counting for methods PCOccSch and PCDesOcc
    OAVolumeFlowRate *= thisZone.Multiplier * thisZone.ListMultiplier;


Multipliers are applied here for all OA control types.

mjwitte · 2025-10-08T16:15:10Z

src/EnergyPlus/OutputReportPredefined.cc

+        addFootNoteSubTable(state,
+                            s->pdstZoneClSize,
+                            "The Design Load is the zone sensible load only. It does not include any system effects or ventilation loads. Values "
+                            "shown include multipliers.");


Extend the footnote for HVAC Sizing Summary tables "Value shown include multipliers."

mjwitte · 2025-10-08T16:15:39Z

src/EnergyPlus/OutputReportPredefined.cc

        s->pdchOaMvZoneArea = newPreDefColumn(state, s->pdstOAmechVentParByZone, "Zone Area [m2]");
        s->pdchOaMvDesZnOa = newPreDefColumn(state, s->pdstOAmechVentParByZone, "Design Zone Outdoor Airflow - Voz [m3/s]");
        s->pdchOaMvMinDynTrgVent = newPreDefColumn(state, s->pdstOAmechVentParByZone, "Minimum Dynamic Target Ventilation - Voz-dyn-min [m3/s]");
+        s->pdchOaMvZoneMult = newPreDefColumn(state, s->pdstOAmechVentParByZone, "Zone Multiplier");


New multiplier column for Outdoor Air Details "by Zone" subtables.

mjwitte · 2025-10-08T16:16:20Z

src/EnergyPlus/OutputReportTabular.cc

+                    PreDefTableEntry(state, state.dataOutRptPredefined->pdchOaMvAvgNumOcc, thisZone.Name, avgOcc);
+                    totalAverageOccupants += avgOcc * zoneMult;
+                } else {
+                    PreDefTableEntry(state, state.dataOutRptPredefined->pdchOaoAvgNumOcc1, thisZone.Name, 0.0);


Fille some table values with zeros for unoccupied zones (previously the cells were left blank).

mjwitte · 2025-10-08T16:17:38Z

src/EnergyPlus/SizingManager.cc

                reportZoneSizing(state,
                                 state.dataHeatBal->space(spaceNum),
                                 state.dataSize->FinalSpaceSizing(spaceNum),
                                 state.dataSize->CalcFinalSpaceSizing(spaceNum),
                                 state.dataSize->CalcSpaceSizing,
                                 state.dataSize->SpaceSizing,
+                                 mult,
                                 isSpace);


Pass new parameter for multiplier to reportZoneSizing.

mjwitte · 2025-10-08T16:18:46Z

src/EnergyPlus/SizingManager.cc

-                            zoneOrSpace.FloorArea,
-                            zoneOrSpace.TotOccupants,
+                            zoneOrSpace.FloorArea * zoneMult,
+                            zoneOrSpace.TotOccupants * zoneMult,


Apply the multiplier to FloorArea and TotOccupants.

mjwitte · 2025-10-08T16:20:16Z

src/EnergyPlus/SizingManager.cc

+            OutputReportPredefined::PreDefTableEntry(state,
+                                                     shift + state.dataOutRptPredefined->pdchZnClUserDesLdPerArea,
+                                                     curName,
+                                                     zsFinalSizing.DesCoolLoad / (zoneOrSpace.FloorArea * zoneMult));


Also need to apply the multiplier here for "User Design Load per Area".

mjwitte · 2025-10-08T16:21:28Z

src/Transition/OutputRulesFiles/OutputChanges25-1-0-to-25-2-0.md


 See Pull Request [#11153](https://github.com/NREL/EnergyPlus/pull/11153).

-### EIO and HTML Table Output: Initialization Summary


OutputChanges was a bit messed up, so it's cleaned up here, along with a new section at the end for this PR.

mitchute · 2025-10-08T20:03:52Z

src/Transition/OutputRulesFiles/OutputChanges25-1-0-to-25-2-0.md

+
+* HVAC Sizing Summary table output values for "User Design Load per Area" have been corrected to properly account for zone multipliers.
+
+See pull request [#11259](https://github.com/NREL/EnergyPlus/pull/10259)


@mjwitte I think this is supposed to be referencing #11259, right?

Whoops, yes.

github-actions · 2025-10-08T20:34:41Z

⚠️ Regressions detected on ubuntu-24.04 for commit `5670be2`

Regression Summary

Audit: 805
Table Big Diffs: 698
Table String Diffs: 89
EIO: 43

github-actions · 2025-10-08T20:37:20Z

⚠️ Regressions detected on macos-14 for commit `5670be2`

Regression Summary

Audit: 801
Table Big Diffs: 696
Table String Diffs: 89
EIO: 43

mjwitte added 4 commits October 7, 2025 13:58

Add zone multiplier to OA details report and put zeroes in blank cells

fbb2668

Merge remote-tracking branch 'remotes/origin/develop' into 10799_Zone…

f527baf

…MultipliersAndOA

Fix zone multipliers for design load per area

5c2acca

Fix zone multipliers for ProportionalControlBasedOn Occupancy

426ac13

mjwitte added Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Oct 7, 2025

mjwitte added this to the EnergyPlus 25.2 IO Freeze milestone Oct 7, 2025

mjwitte added 3 commits October 8, 2025 08:08

Format

e40e945

Output rules cleanup

6bc4a8f

New output changes

c729cff

mjwitte marked this pull request as ready for review October 8, 2025 16:04

mjwitte commented Oct 8, 2025

View reviewed changes

mitchute reviewed Oct 8, 2025

View reviewed changes

fix link

c033a1c

mitchute approved these changes Oct 8, 2025

View reviewed changes

mitchute merged commit a94ab1f into develop Oct 9, 2025
11 checks passed

mitchute deleted the 10799_ZoneMultipliersAndOA branch October 9, 2025 01:58


		See Pull Request [#11153](https://github.com/NREL/EnergyPlus/pull/11153).

		### EIO and HTML Table Output: Initialization Summary


		* HVAC Sizing Summary table output values for "User Design Load per Area" have been corrected to properly account for zone multipliers.

		See pull request [#11259](https://github.com/NREL/EnergyPlus/pull/10259)

Conversation

mjwitte commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Reviewer

Uh oh!

github-actions bot commented Oct 7, 2025

⚠️ Regressions detected on macos-14 for commit bae4e6c

Uh oh!

github-actions bot commented Oct 7, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit bae4e6c

Uh oh!

rraustad commented Oct 8, 2025

Uh oh!

mjwitte commented Oct 8, 2025

Uh oh!

mjwitte commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 1d98238

Uh oh!

mjwitte commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on macos-14 for commit 1d98238

Uh oh!

mjwitte commented Oct 8, 2025

Uh oh!

mjwitte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 5670be2

Uh oh!

github-actions bot commented Oct 8, 2025

⚠️ Regressions detected on macos-14 for commit 5670be2

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mjwitte commented Oct 7, 2025 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `bae4e6c`

⚠️ Regressions detected on ubuntu-24.04 for commit `bae4e6c`

⚠️ Regressions detected on ubuntu-24.04 for commit `1d98238`

⚠️ Regressions detected on macos-14 for commit `1d98238`

⚠️ Regressions detected on ubuntu-24.04 for commit `5670be2`

⚠️ Regressions detected on macos-14 for commit `5670be2`