Skip to content

ZoneHVAC:ExhaustControl correct schedule used for exhaust flow rate calculation#11230

Merged
mitchute merged 5 commits intodevelopfrom
11228-ZoneExhaustControl
Sep 25, 2025
Merged

ZoneHVAC:ExhaustControl correct schedule used for exhaust flow rate calculation#11230
mitchute merged 5 commits intodevelopfrom
11228-ZoneExhaustControl

Conversation

@rraustad
Copy link
Collaborator

@rraustad rraustad commented Sep 24, 2025 •
edited
Loading

Pull request overview

Description of the purpose of this PR

Incorrect schedule pointer was used for zone exhaust (was using min exhaust schedule)

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added this to the EnergyPlus 25.2 milestone Sep 24, 2025
@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit bbc5fd7

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

⚠️ Regressions detected on macos-14 for commit bbc5fd7

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on macos-14 for commit 0924660

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit 0924660

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit aa664a7

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

⚠️ Regressions detected on macos-14 for commit aa664a7

Regression Summary
  • ERR: 1
  • MTR Small Diffs: 1
  • Table Big Diffs: 1

@rraustad rraustad changed the title ZoneHVAC:ExhaustControl correct schedule use for exhaust flow rate and update unit test ZoneHVAC:ExhaustControl correct schedule used for exhaust flow rate calculation Sep 25, 2025
@rraustad
Copy link
Collaborator Author

rraustad commented Sep 25, 2025

The single err diff shows the exhaust is now working.

+   ** Warning ** In zone SPACE1-1 there is unbalanced air flow. Load due to induced outdoor air is neglected.
+   **   ~~~   **  Environment=CHICAGO_IL_USA ANNUAL COOLING 1% DESIGN CONDITIONS DB/MCWB, at Simulation time=07/21 08:00 - 08:15
+   **   ~~~   **   Flows [m3/s]: Inlets: 0.102912  Unbalanced exhausts: 8.504235E-002  Returns: 4.670869E-002
+   **   ~~~   **   Infiltration: 0.000000  Zone Ventilation: 0.000000  Mixing (incoming): 0.000000
+   **   ~~~   **   Imbalance (excess outflow): 2.883855E-002  Total system OA flow (for all airloops serving this zone): 0.000000
+   **   ~~~   **   This error will only be reported once per zone.

@mitchute mitchute merged commit 5fca707 into develop Sep 25, 2025
11 checks passed
@mitchute mitchute deleted the 11228-ZoneExhaustControl branch September 25, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

ZoneHVAC:ExhaustControl does not work

3 participants

@rraustad @nrel-bot-2c @mitchute